From 934c72979b9f285ed477ba99cf3bdf536dda1168 Mon Sep 17 00:00:00 2001
From: Dan Poltawski <dan@moodle.com>
Date: Sat, 29 Nov 2014 12:19:56 +0000
Subject: [PATCH] MDL-40552 course: fixup unit test

Previously there was an assertion which was never used, now
we ensure to test the course themes functionality each time.
---
 course/tests/externallib_test.php | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/course/tests/externallib_test.php b/course/tests/externallib_test.php
index 9f70969fb55f8..37bd1a8c5ecef 100644
--- a/course/tests/externallib_test.php
+++ b/course/tests/externallib_test.php
@@ -335,6 +335,8 @@ public function test_create_courses() {
 
         // Enable course completion.
         set_config('enablecompletion', 1);
+        // Enable course themes.
+        set_config('allowcoursethemes', 1);
 
         // Set the required capabilities by the external function
         $contextid = context_system::instance()->id;
@@ -415,10 +417,7 @@ public function test_create_courses() {
                 $this->assertEquals($courseinfo->defaultgroupingid, $course2['defaultgroupingid']);
                 $this->assertEquals($courseinfo->completionnotify, $course2['completionnotify']);
                 $this->assertEquals($courseinfo->lang, $course2['lang']);
-
-                if (!empty($CFG->allowcoursethemes)) {
-                    $this->assertEquals($courseinfo->theme, $course2['forcetheme']);
-                }
+                $this->assertEquals($courseinfo->theme, $course2['forcetheme']);
 
                 // We enabled completion at the beginning of the test.
                 $this->assertEquals($courseinfo->enablecompletion, $course2['enablecompletion']);