Permalink
Browse files

MDL-34658 - Saving failed because missing or false values

  • Loading branch information...
1 parent 470d47f commit 94848b0748b604da1cfb00b72f7109bfe949fd0c @grabs grabs committed Aug 2, 2012
Showing with 11 additions and 3 deletions.
  1. +6 −1 mod/feedback/item/numeric/lib.php
  2. +5 −2 mod/feedback/lib.php
View
7 mod/feedback/item/numeric/lib.php
@@ -540,8 +540,13 @@ public function value_type() {
}
public function clean_input_value($value) {
+ $value = str_replace($this->sep_dec, FEEDBACK_DECIMAL, $value);
if (!is_numeric($value)) {
- return null;
+ if ($value == '') {
+ return null; //an empty string should be null
+ } else {
+ return clean_param($value, PARAM_TEXT); //we have to know the value if it is wrong
+ }
}
return clean_param($value, $this->value_type());
}
View
7 mod/feedback/lib.php
@@ -2195,10 +2195,13 @@ function feedback_check_values($firstitem, $lastitem) {
$formvalname = $item->typ . '_' . $item->id;
if ($itemobj->value_is_array()) {
- $value = optional_param_array($formvalname, null, $itemobj->value_type());
+ //get the raw value here. It is cleaned after that by the object itself
+ $value = optional_param_array($formvalname, null, PARAM_RAW);
} else {
- $value = optional_param($formvalname, null, $itemobj->value_type());
+ //get the raw value here. It is cleaned after that by the object itself
+ $value = optional_param($formvalname, null, PARAM_RAW);
}
+ $value = $itemobj->clean_input_value($value);
//check if the value is set
if (is_null($value) AND $item->required == 1) {

0 comments on commit 94848b0

Please sign in to comment.