Permalink
Browse files

MDL-13048 fix undefined course id when importing a Hot Potatoes quiz …

…into the Lesson module
  • Loading branch information...
1 parent 40777e9 commit 95fcbce2a16a549b212ccb01a7d6a8fb129eccf7 gbateson committed Feb 5, 2008
Showing with 21 additions and 4 deletions.
  1. +21 −4 question/format/hotpot/format.php
@@ -20,12 +20,29 @@ function readquestions ($lines) {
/// where each item is a question object as defined by
/// readquestion().
- // set baseurl
- global $CFG;
+ // set courseid and baseurl
+ global $CFG, $COURSE, $course;
+ switch (true) {
+ case isset($this->course->id):
+ // import to quiz module
+ $courseid = $this->course->id;
+ break;
+ case isset($course->id):
+ // import to lesson module
+ $courseid = $course->id;
+ break;
+ case isset($COURSE->id):
+ // last resort
+ $courseid = $COURSE->id;
+ break;
+ default:
+ // shouldn't happen !!
+ $courseid = 0;
+ }
if ($CFG->slasharguments) {
- $baseurl = "$CFG->wwwroot/file.php/{$this->course->id}/";
+ $baseurl = "$CFG->wwwroot/file.php/$courseid/";
} else {
- $baseurl = "$CFG->wwwroot/file.php?file=/{$this->course->id}/";
+ $baseurl = "$CFG->wwwroot/file.php?file=/$courseid/";
}
// get import file name

0 comments on commit 95fcbce

Please sign in to comment.