Skip to content
Browse files

MDL-28568 message: added a warning message when the user is about to …

…message someone who cant reply
  • Loading branch information...
1 parent 9a7c3d5 commit 9e198bd6a68fc0cb255bae5ca310e256f3ed2317 @andyjdavis andyjdavis committed Jul 18, 2012
Showing with 16 additions and 3 deletions.
  1. +2 −1 lang/en/message.php
  2. +13 −2 message/index.php
  3. +1 −0 theme/standard/style/core.css
View
3 lang/en/message.php
@@ -82,6 +82,7 @@
$string['messagehistoryfull'] = 'All messages';
$string['messages'] = 'Messages';
$string['messaging'] = 'Messaging';
+$string['messagingblockednoncontact'] = '{$a} will not be able to reply as you have blocked non-contacts';
$string['messagingdisabled'] = 'Messaging is disabled on this site, emails will be sent instead';
$string['mycontacts'] = 'My contacts';
$string['newonlymsg'] = 'Show only new';
@@ -139,5 +140,5 @@
$string['unreadnewnotification'] = 'New notification';
$string['unreadnewnotifications'] = 'New notifications ({$a})';
$string['userisblockingyou'] = 'This user has blocked you from sending messages to them';
-$string['userisblockingyounoncontact'] = 'This user is only accepting messages from people listed as contacts, and you are not currently on the list.';
+$string['userisblockingyounoncontact'] = '{$a} only accepts messages from their contacts.';
$string['userssearchresults'] = 'Users found: {$a}';
View
15 message/index.php
@@ -154,7 +154,7 @@
if (!empty($userpreferences['message_blocknoncontacts'])) { // User is blocking non-contacts
if (empty($contact)) { // We are not a contact!
- $messageerror = get_string('userisblockingyounoncontact', 'message');
+ $messageerror = get_string('userisblockingyounoncontact', 'message', fullname($user2));
}
}
@@ -288,8 +288,19 @@
if ($currentuser && has_capability('moodle/site:sendmessage', $context)) {
echo html_writer::start_tag('div', array('class' => 'mdl-align messagesend'));
if (!empty($messageerror)) {
- echo $OUTPUT->heading($messageerror, 3);
+ echo html_writer::tag('span', $messageerror, array('id' => 'messagewarning'));
} else {
+ // Display a warning if the current user is blocking non-contacts and is about to message to a non-contact
+ // Otherwise they may wonder why they never get a reply
+ $blocknoncontacts = get_user_preferences('message_blocknoncontacts', '', $user1->id);
+ if (!empty($blocknoncontacts)) {
+ $contact = $DB->get_record('message_contacts', array('userid' => $user1->id, 'contactid' => $user2->id));
+ if (empty($contact)) {
+ $msg = get_string('messagingblockednoncontact', 'message', fullname($user2));
+ echo html_writer::tag('span', $msg, array('id' => 'messagewarning'));
+ }
+ }
+
$mform = new send_form();
$defaultmessage = new stdClass;
$defaultmessage->id = $user2->id;
View
1 theme/standard/style/core.css
@@ -451,3 +451,4 @@ table#tag-management-list {margin: 10px auto;width: 80%;}
#page-message-edit table.generaltable th.c0 {text-align: left;}
#page-message-edit table.generaltable td.c0 {text-align: right;}
#page-message-edit table.generaltable td.disallowed {text-align: center;vertical-align:middle;}
+#messagewarning {font-style:italic;}

0 comments on commit 9e198bd

Please sign in to comment.
Something went wrong with that request. Please try again.