diff --git a/report/completion/index.php b/report/completion/index.php index a235511805627..73380d7e011aa 100644 --- a/report/completion/index.php +++ b/report/completion/index.php @@ -546,7 +546,7 @@ if ($csv) { $row = array(); $row[] = $user->id; - $row[] = fullname($user); + $row[] = fullname($user, has_capability('moodle/site:viewfullnames', $context)); foreach ($extrafields as $field) { $row[] = $user->{$field}; } @@ -559,7 +559,8 @@ $userurl = new moodle_url('/user/view.php', array('id' => $user->id, 'course' => $course->id)); } - print ''.fullname($user).''; + print '' . + fullname($user, has_capability('moodle/site:viewfullnames', $context)) . ''; foreach ($extrafields as $field) { echo ''.s($user->{$field}).''; } diff --git a/report/completion/tests/behat/completion_report.feature b/report/completion/tests/behat/completion_report.feature new file mode 100644 index 0000000000000..0f2af7b930a48 --- /dev/null +++ b/report/completion/tests/behat/completion_report.feature @@ -0,0 +1,37 @@ +@report @report_completion +Feature: See the completion for items in a course + In order see completion data + As a teacher + I need to view completion report + + Background: + Given the following "users" exist: + | username | firstname | lastname | email | idnumber | middlename | alternatename | firstnamephonetic | lastnamephonetic | + | teacher1 | Teacher | 1 | teacher1@example.com | t1 | | fred | | | + | student1 | Grainne | Beauchamp | student1@example.com | s1 | Ann | Jill | Gronya | Beecham | + And the following "courses" exist: + | fullname | shortname | category | enablecompletion | + | Course 1 | C1 | 0 | 1 | + And the following "course enrolments" exist: + | user | course | role | + | teacher1 | C1 | editingteacher | + | student1 | C1 | student | + And the following "activities" exist: + | activity | name | intro | course | idnumber | completion | completionview | + | page | PageName1 | PageDesc1 | C1 | PAGE1 | 1 | 1 | + And the following config values are set as admin: + | fullnamedisplay | firstname | + | alternativefullnameformat | middlename, alternatename, firstname, lastname | + + @javascript + Scenario: Go to the completion report + Given I log in as "teacher1" + And I am on "Course 1" course homepage + And I navigate to "Course completion" in current page administration + And I expand all fieldsets + And I set the following fields to these values: + | Page - PageName1 | 1 | + And I press "Save changes" + And I am on "Course 1" course homepage + When I navigate to "Reports > Course completion" in current page administration + Then I should see "Ann, Jill, Grainne, Beauchamp"