Permalink
Browse files

prevent NULL contents before field change (old servers can have this …

…wrongly defined). MDL-14859
  • Loading branch information...
1 parent 2ecc706 commit a326872b88d02ddf7cb0b6eb51f6a92aa5c323fd stronk7 committed May 15, 2008
Showing with 5 additions and 0 deletions.
  1. +5 −0 lib/db/upgrade.php
View
@@ -2970,6 +2970,11 @@ function xmldb_main_upgrade($oldversion=0) {
if ($result && $oldversion < 2007101512) {
notify('Increasing size of user idnumber field, this may take a while...', 'notifysuccess');
+ /// Under MySQL and Postgres... detect old NULL contents and change them by correct empty string. MDL-14859
+ if ($CFG->dbfamily == 'mysql' || $CFG->dbfamily == 'postgres') {
+ execute_sql("UPDATE {$CFG->prefix}user SET idnumber = '' WHERE idnumber IS NULL", true);
+ }
+
/// Define index idnumber (not unique) to be dropped form user
$table = new XMLDBTable('user');
$index = new XMLDBIndex('idnumber');

0 comments on commit a326872

Please sign in to comment.