MDL-44482 mod_lti: use localized dates

Fixed an issue where LTI external tools had creation datestamps of NaN/NaN/NaN under particular non-English languages.
moodle · May 26, 2014 · addeb65 · addeb65
1 parent 529d4cd
commit addeb65
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/mod/lti/locallib.php b/mod/lti/locallib.php
@@ -360,7 +360,7 @@ function lti_get_tool_table($tools, $id) {
         ";
 
         foreach ($tools as $type) {
-            $date = userdate($type->timecreated);
+            $date = userdate($type->timecreated, get_string('strftimedatefullshort', 'core_langconfig'));
             $accept = get_string('accept', 'lti');
             $update = get_string('update', 'lti');
             $delete = get_string('delete', 'lti');

diff --git a/mod/lti/settings.php b/mod/lti/settings.php
@@ -144,7 +144,7 @@
                 var configuredColumns = [
                     {key:'name', label:'$typename', sortable:true},
                     {key:'baseURL', label:'$baseurl', sortable:true},
-                    {key:'timecreated', label:'$createdon', sortable:true, formatter:Y.YUI2.widget.DataTable.formatDate},
+                    {key:'timecreated', label:'$createdon', sortable:true},
                     {key:'action', label:'$action'}
                 ];
 
@@ -153,7 +153,7 @@
                     fields: [
                         {key:'name'},
                         {key:'baseURL'},
-                        {key:'timecreated', parser:'date'},
+                        {key:'timecreated'},
                         {key:'action'}
                     ]
                 };