Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

MDL-29396 core: ip blocking will be bypassed for cli scripts - Thanks…

… Petr
  • Loading branch information...
commit b25603680e8141a80a7618b15f0814edb012e305 1 parent f28832d
Rajesh Taneja authored
Showing with 8 additions and 6 deletions.
  1. +8 −6 lib/setup.php
View
14 lib/setup.php
@@ -788,12 +788,14 @@ function stripslashes_deep($value) {
}
}
-// in the first case, ip in allowed list will be performed first
-// for example, client IP is 192.168.1.1
-// 192.168 subnet is an entry in allowed list
-// 192.168.1.1 is banned in blocked list
-// This ip will be banned finally
-if (!empty($CFG->allowbeforeblock)) { // allowed list processed before blocked list?
+if (CLI_SCRIPT and !defined('WEB_CRON_EMULATED_CLI') and !PHPUNIT_SCRIPT) {
+ // no ip blocking
+} else if (!empty($CFG->allowbeforeblock)) { // allowed list processed before blocked list?
+ // in this case, ip in allowed list will be performed first
+ // for example, client IP is 192.168.1.1
+ // 192.168 subnet is an entry in allowed list
+ // 192.168.1.1 is banned in blocked list
+ // This ip will be banned finally
if (!empty($CFG->allowedip)) {
if (!remoteip_in_list($CFG->allowedip)) {
die(get_string('ipblocked', 'admin'));
Please sign in to comment.
Something went wrong with that request. Please try again.