Browse files

get_my_courses() - tighten default fields - faster, risky

This makes get_my_courses() faster/lighter in 2 ways

 - We fetch a ton less data from the DB
 - We store a tone less data in the Session

In a test environment, with a student enrolled in  3 _empty_ courses
(just created, empty modinfo, etc), this shaves 50% off the session
size on-disk.

The problem is callers that may be expecting a given field to appear by
default. Next step: walk all callers...
  • Loading branch information...
1 parent a728edc commit b5f523ab6ef989ae69593cf6e650af5ea79a7178 martinlanghoff committed May 6, 2007
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/datalib.php
@@ -686,7 +686,7 @@ function get_my_courses($userid, $sort=NULL, $fields=NULL, $doanything=false,$li
// Default parameters
$d_sort = 'visible DESC,sortorder ASC';
- $d_fields = '*';
+ $d_fields = 'id, category, sortorder, shortname, fullname, idnumber, newsitems, teacher, teachers, student, students, guest, startdate, visible, cost, enrol, summary';
$usingdefaults = true;
if (is_null($sort)) {

0 comments on commit b5f523a

Please sign in to comment.