Permalink
Browse files

MDL-26704 gradebook: added some intelligence to the dates displayed o…

…n the user outline activity report
  • Loading branch information...
1 parent d221a38 commit b66705e52c33f5cdfa07712a852a23c1c3aaa7be @andyjdavis andyjdavis committed May 6, 2011
Showing with 54 additions and 7 deletions.
  1. +9 −1 mod/data/lib.php
  2. +9 −1 mod/forum/lib.php
  3. +9 −1 mod/glossary/lib.php
  4. +8 −1 mod/lesson/lib.php
  5. +9 −1 mod/quiz/lib.php
  6. +10 −2 mod/scorm/lib.php
View
@@ -729,7 +729,15 @@ function data_user_outline($course, $user, $mod, $data) {
} else if ($grade) {
$result = new object();
$result->info = get_string('grade') . ': ' . $grade->str_long_grade;
- $result->time = $grade->dategraded;
+
+ //datesubmitted == time created. dategraded == time modified or time overridden
+ //if grade was last modified by the user themselves use date graded. Otherwise use date submitted
+ if ($grade->usermodified == $user->id || empty($grade->datesubmitted)) {
+ $result->time = $grade->dategraded;
+ } else {
+ $result->time = $grade->datesubmitted;
+ }
+
return $result;
}
return NULL;
View
@@ -976,7 +976,15 @@ function forum_user_outline($course, $user, $mod, $forum) {
} else if ($grade) {
$result = new object();
$result->info = get_string('grade') . ': ' . $grade->str_long_grade;
- $result->time = $grade->dategraded;
+
+ //datesubmitted == time created. dategraded == time modified or time overridden
+ //if grade was last modified by the user themselves use date graded. Otherwise use date submitted
+ if ($grade->usermodified == $user->id || empty($grade->datesubmitted)) {
+ $result->time = $grade->dategraded;
+ } else {
+ $result->time = $grade->datesubmitted;
+ }
+
return $result;
}
return NULL;
View
@@ -189,7 +189,15 @@ function glossary_user_outline($course, $user, $mod, $glossary) {
} else if ($grade) {
$result = new object();
$result->info = get_string('grade') . ': ' . $grade->str_long_grade;
- $result->time = $grade->dategraded;
+
+ //datesubmitted == time created. dategraded == time modified or time overridden
+ //if grade was last modified by the user themselves use date graded. Otherwise use date submitted
+ if ($grade->usermodified == $user->id || empty($grade->datesubmitted)) {
+ $result->time = $grade->dategraded;
+ } else {
+ $result->time = $grade->datesubmitted;
+ }
+
return $result;
}
View
@@ -155,7 +155,14 @@ function lesson_user_outline($course, $user, $mod, $lesson) {
} else {
$grade = reset($grades->items[0]->grades);
$return->info = get_string("grade") . ': ' . $grade->str_long_grade;
- $return->time = $grade->dategraded;
+
+ //datesubmitted == time created. dategraded == time modified or time overridden
+ //if grade was last modified by the user themselves use date graded. Otherwise use date submitted
+ if ($grade->usermodified == $user->id || empty($grade->datesubmitted)) {
+ $result->time = $grade->dategraded;
+ } else {
+ $result->time = $grade->datesubmitted;
+ }
}
return $return;
}
View
@@ -209,7 +209,15 @@ function quiz_user_outline($course, $user, $mod, $quiz) {
$result = new stdClass;
$result->info = get_string('grade') . ': ' . $grade->str_long_grade;
- $result->time = $grade->dategraded;
+
+ //datesubmitted == time created. dategraded == time modified or time overridden
+ //if grade was last modified by the user themselves use date graded. Otherwise use date submitted
+ if ($grade->usermodified == $user->id || empty($grade->datesubmitted)) {
+ $result->time = $grade->dategraded;
+ } else {
+ $result->time = $grade->datesubmitted;
+ }
+
return $result;
}
View
@@ -225,7 +225,15 @@ function scorm_user_outline($course, $user, $mod, $scorm) {
$grade = reset($grades->items[0]->grades);
$result = new object();
$result->info = get_string('grade') . ': '. $grade->str_long_grade;
- $result->time = $grade->dategraded;
+
+ //datesubmitted == time created. dategraded == time modified or time overridden
+ //if grade was last modified by the user themselves use date graded. Otherwise use date submitted
+ if ($grade->usermodified == $user->id || empty($grade->datesubmitted)) {
+ $result->time = $grade->dategraded;
+ } else {
+ $result->time = $grade->datesubmitted;
+ }
+
return $result;
}
return null;
@@ -664,4 +672,4 @@ function scorm_is_moddata_trusted() {
return true;
}
-?>
+?>

0 comments on commit b66705e

Please sign in to comment.