Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

MDL-34648 Chat: No more errors when sentence begin with 'To'

  • Loading branch information...
commit bc2289cd528914dab229ccee0a5056508b3adc06 1 parent 7033316
@FMCorz FMCorz authored
Showing with 47 additions and 32 deletions.
  1. +47 −32 mod/chat/lib.php
View
79 mod/chat/lib.php
@@ -767,16 +767,15 @@ function chat_format_message_manually($message, $courseid, $sender, $currentuser
}
// It's not a system event
-
- $text = $message->message;
+ $text = trim($message->message);
/// Parse the text to clean and filter it
-
$options = new stdClass();
$options->para = false;
$text = format_text($text, FORMAT_MOODLE, $options, $courseid);
// And now check for special cases
+ $patternTo = '#^\s*To\s([^:]+):(.*)#';
$special = false;
if (substr($text, 0, 5) == 'beep ') {
@@ -799,23 +798,32 @@ function chat_format_message_manually($message, $courseid, $sender, $currentuser
return false;
}
} else if (substr($text, 0, 1) == '/') { /// It's a user command
- // support some IRC commands
+ $special = true;
$pattern = '#(^\/)(\w+).*#';
- preg_match($pattern, trim($text), $matches);
- $command = $matches[2];
+ preg_match($pattern, $text, $matches);
+ $command = isset($matches[2]) ? $matches[2] : false;
+ // Support some IRC commands.
switch ($command){
- case 'me':
- $special = true;
- $outinfo = $message->strtime;
- $outmain = '*** <b>'.$sender->firstname.' '.substr($text, 4).'</b>';
- break;
+ case 'me':
+ $outinfo = $message->strtime;
+ $outmain = '*** <b>'.$sender->firstname.' '.substr($text, 4).'</b>';
+ break;
+ default:
+ // Error, we set special back to false to use the classic message output.
+ $special = false;
+ break;
}
- } elseif (substr($text, 0, 2) == 'To') {
- $pattern = '#To[[:space:]](.*):(.*)#';
- preg_match($pattern, trim($text), $matches);
+ } else if (preg_match($patternTo, $text)) {
$special = true;
- $outinfo = $message->strtime;
- $outmain = $sender->firstname.' '.get_string('saidto', 'chat').' <i>'.$matches[1].'</i>: '.$matches[2];
+ $matches = array();
+ preg_match($patternTo, $text, $matches);
+ if (isset($matches[1]) && isset($matches[2])) {
+ $outinfo = $message->strtime;
+ $outmain = $sender->firstname.' '.get_string('saidto', 'chat').' <i>'.$matches[1].'</i>: '.$matches[2];
+ } else {
+ // Error, we set special back to false to use the classic message output.
+ $special = false;
+ }
}
if(!$special) {
@@ -929,7 +937,7 @@ function chat_format_message_theme ($message, $chatuser, $currentuser, $grouping
}
// It's not a system event
- $text = $message->message;
+ $text = trim($message->message);
/// Parse the text to clean and filter it
$options = new stdClass();
@@ -940,8 +948,9 @@ function chat_format_message_theme ($message, $chatuser, $currentuser, $grouping
$special = false;
$outtime = $message->strtime;
- //Initilise output variable.
+ // Initialise variables.
$outmain = '';
+ $patternTo = '#^\s*To\s([^:]+):(.*)#';
if (substr($text, 0, 5) == 'beep ') {
$special = true;
@@ -969,26 +978,33 @@ function chat_format_message_theme ($message, $chatuser, $currentuser, $grouping
} else if (substr($text, 0, 1) == '/') { /// It's a user command
$special = true;
$result->type = 'command';
- // support some IRC commands
$pattern = '#(^\/)(\w+).*#';
- preg_match($pattern, trim($text), $matches);
- $command = $matches[2];
- $special = true;
+ preg_match($pattern, $text, $matches);
+ $command = isset($matches[2]) ? $matches[2] : false;
+ // Support some IRC commands.
switch ($command){
- case 'me':
- $outmain = '*** <b>'.$sender->firstname.' '.substr($text, 4).'</b>';
- break;
+ case 'me':
+ $outmain = '*** <b>'.$sender->firstname.' '.substr($text, 4).'</b>';
+ break;
+ default:
+ // Error, we set special back to false to use the classic message output.
+ $special = false;
+ break;
}
- } elseif (substr($text, 0, 2) == 'To') {
+ } else if (preg_match($patternTo, $text)) {
$special = true;
$result->type = 'dialogue';
- $pattern = '#To[[:space:]](.*):(.*)#';
- preg_match($pattern, trim($text), $matches);
- $special = true;
- $outmain = $sender->firstname.' <b>'.get_string('saidto', 'chat').'</b> <i>'.$matches[1].'</i>: '.$matches[2];
+ $matches = array();
+ preg_match($patternTo, $text, $matches);
+ if (isset($matches[1]) && isset($matches[2])) {
+ $outmain = $sender->firstname.' <b>'.get_string('saidto', 'chat').'</b> <i>'.$matches[1].'</i>: '.$matches[2];
+ } else {
+ // Error, we set special back to false to use the classic message output.
+ $special = false;
+ }
}
- if(!$special) {
+ if (!$special) {
$outmain = $text;
}
@@ -1034,7 +1050,6 @@ function chat_format_message_theme ($message, $chatuser, $currentuser, $grouping
}
}
-
/**
* @global object $DB
* @global object $CFG
Please sign in to comment.
Something went wrong with that request. Please try again.