Skip to content
Browse files

Now make_upload_directory() is used, avoiding dependencies to

backup/lib.php. I think that, gradually, I'll can modify the
backup/restore process to use this "core" function everywhere!!
Bug 1467.
(http://moodle.org/bugs/bug.php?op=show&bugid=1467)
  • Loading branch information...
1 parent 555fd3f commit bc706aeb5f2b726eeb2513482cfb4c989667d786 stronk7 committed May 26, 2004
Showing with 6 additions and 10 deletions.
  1. +0 −1 admin/cron.php
  2. +6 −9 rss/rsslib.php
View
1 admin/cron.php
@@ -149,7 +149,6 @@
if (!empty($CFG->enablerssfeeds)) { //Defined in admin/variables page
if (file_exists("$CFG->dirroot/rss/rsslib.php")) {
- include_once("$CFG->dirroot/backup/lib.php"); // Unfortunately this is required
include_once("$CFG->dirroot/rss/rsslib.php");
echo "Running rssfeeds if required...\n";
flush();
View
15 rss/rsslib.php
@@ -92,22 +92,19 @@ function rss_save_file ($modname,$mod,$result) {
$status = true;
- $basedir = $CFG->dataroot."/rss";
-
- //Check dataroot/rss exists
- $status = check_dir_exists($basedir,true);
-
- $basedir .= "/".$modname;
-
- //Check dataroot/rrs/$modname exists
- $status = check_dir_exists($basedir,true);
+ if (! $basedir = make_upload_directory ("rss/".$modname)) {
+ //Cannot be created, so error
+ $status = false;
+ }
if ($status) {
$file = $basedir .= "/".$mod->id.".xml";
$rss_file = fopen($file,"w");
if ($rss_file) {
$status = fwrite ($rss_file,$result);
fclose($rss_file);
+ } else {
+ $status = false;
}
}
return $status;

0 comments on commit bc706ae

Please sign in to comment.
Something went wrong with that request. Please try again.