Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

MDL-32062 question engine: fixup tests that this change broke.

The test data was wrong, and was triggering the work-around code that
MDL-32062 introduced. I fixed the test data.

Also, I fixed one of the tests, that had been broken.
  • Loading branch information...
commit bf92acc2530f46711ffaa3925882ace38f617d8a 1 parent e255439
@timhunt timhunt authored
Showing with 3 additions and 9 deletions.
  1. +3 −9 question/engine/tests/unitofwork_test.php
View
12 question/engine/tests/unitofwork_test.php
@@ -126,7 +126,7 @@ protected function get_test_data() {
array(1, 1, 'unit_test', 'interactive', 1, 123, 1, 1, 'interactive', -1, 1, 1.0000000, 0.0000000, 0, '', '', '', 1256233790, 2, 1, 'todo', null, 1256233720, 1, '-_triesleft', 1),
array(1, 1, 'unit_test', 'interactive', 1, 123, 1, 1, 'interactive', -1, 1, 1.0000000, 0.0000000, 0, '', '', '', 1256233790, 3, 2, 'todo', null, 1256233740, 1, '-tryagain', 1),
array(1, 1, 'unit_test', 'interactive', 1, 123, 1, 1, 'interactive', -1, 1, 1.0000000, 0.0000000, 0, '', '', '', 1256233790, 5, 3, 'gradedright', null, 1256233790, 1, 'answer', 'frog'),
- array(1, 1, 'unit_test', 'interactive', 1, 123, 1, 1, 'interactive', -1, 1, 1.0000000, 0.0000000, 0, '', '', '', 1256233790, 5, 3, 'gradedright', 1.0000000, 1256233790, 1, '-finish', 1),
+ array(1, 1, 'unit_test', 'interactive', 1, 123, 1, 1, 'interactive', -1, 1, 1.0000000, 0.0000000, 0, '', '', '', 1256233790, 5, 3, 'gradedright', 1.0000000, 1256233790, 1, '-submit', 1),
);
}
@@ -196,13 +196,7 @@ public function test_process_action() {
public function test_regrade_same_steps() {
// Change the question in a minor way and regrade.
- if (!isset($this->quba->get_question($this->slot)->answer)) {
- $this->quba->get_question($this->slot)->answer = array();
- }
- if (!isset($this->quba->get_question($this->slot)->answer[14])) {
- $this->quba->get_question($this->slot)->answer[14] = new stdClass();
- }
- $this->quba->get_question($this->slot)->answer[14]->fraction = 0.5;
+ $this->quba->get_question($this->slot)->answers[14]->fraction = 0.5;
$this->quba->regrade_all_questions();
// Here, the qa, and all the steps, should be marked as updated.
@@ -258,7 +252,7 @@ public function test_regrade_losing_steps() {
$this->assertEquals(array('-tryagain' => 1), $firstdeletedstep->get_all_data());
$seconddeletedstep = end($deletedsteps);
- $this->assertEquals(array('answer' => 'frog', '-finish' => 1),
+ $this->assertEquals(array('answer' => 'frog', '-submit' => 1),
$seconddeletedstep->get_all_data());
}
Please sign in to comment.
Something went wrong with that request. Please try again.