Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

MDL-33042: Assign: get rid of email statements in messaging functions

  • Loading branch information...
commit c1d09c6fa39efa0bc7ee5197648b9d85bb1f5a72 1 parent 4631e39
Ruslan Kabalin authored
Showing with 11 additions and 11 deletions.
  1. +11 −11 mod/assign/locallib.php
View
22 mod/assign/locallib.php
@@ -1126,7 +1126,7 @@ static function cron() {
// Simple array we'll use for caching modules.
$modcache = array();
- // Email students about new feedback
+ // Message students about new feedback
foreach ($submissions as $submission) {
mtrace("Processing assignment submission $submission->id ...");
@@ -2377,7 +2377,7 @@ private static function format_notification_message_html($messagetype, $info, $c
}
/**
- * email someone about something (static so it can be called from cron)
+ * Message someone about something (static so it can be called from cron)
*
* @param stdClass $userfrom
* @param stdClass $userto
@@ -2426,7 +2426,7 @@ public static function send_assignment_notification($userfrom, $userto, $message
}
/**
- * email someone about something
+ * Message someone about something
*
* @param stdClass $userfrom
* @param stdClass $userto
@@ -2440,13 +2440,13 @@ public function send_notification($userfrom, $userto, $messagetype, $eventtype,
}
/**
- * Email student upon successful submission
+ * Notify student upon successful submission
*
* @global moodle_database $DB
* @param stdClass $submission
* @return void
*/
- private function email_student_submission_receipt(stdClass $submission) {
+ private function notify_student_submission_receipt(stdClass $submission) {
global $DB;
$adminconfig = $this->get_admin_config();
@@ -2459,13 +2459,13 @@ private function email_student_submission_receipt(stdClass $submission) {
}
/**
- * Email graders upon student submissions
+ * Send notifications to graders upon student submissions
*
* @global moodle_database $DB
* @param stdClass $submission
* @return void
*/
- private function email_graders(stdClass $submission) {
+ private function notify_graders(stdClass $submission) {
global $DB;
$late = $this->get_instance()->duedate && ($this->get_instance()->duedate < time());
@@ -2505,8 +2505,8 @@ private function process_submit_for_grading() {
$submission->status = ASSIGN_SUBMISSION_STATUS_SUBMITTED;
$this->update_submission($submission);
$this->add_to_log('submit for grading', $this->format_submission_for_log($submission));
- $this->email_graders($submission);
- $this->email_student_submission_receipt($submission);
+ $this->notify_graders($submission);
+ $this->notify_student_submission_receipt($submission);
}
}
@@ -2738,8 +2738,8 @@ private function process_save_submission(&$mform) {
$this->add_to_log('submit', $this->format_submission_for_log($submission));
if (!$this->get_instance()->submissiondrafts) {
- $this->email_student_submission_receipt($submission);
- $this->email_graders($submission);
+ $this->notify_student_submission_receipt($submission);
+ $this->notify_graders($submission);
}
return true;
}
Please sign in to comment.
Something went wrong with that request. Please try again.