Permalink
Browse files

MDL-28040 navigation: Fixed up error with navigation when dealing wit…

…h categories that have a lower sort order than the parent.
  • Loading branch information...
1 parent f6f6138 commit c4afcf84d9683526968c41f3060a08932b4d143c Sam Hemelryk committed Jul 13, 2011
Showing with 8 additions and 4 deletions.
  1. +8 −4 lib/navigationlib.php
View
@@ -1395,7 +1395,7 @@ protected function load_all_categories($categoryid = null, $showbasecategories =
$coursestoload = array();
if (empty($categoryid)) { // can be 0
// We are going to load all of the first level categories (categories without parents)
- $categories = $DB->get_records('course_categories', array('parent'=>'0'), 'sortorder');
+ $categories = $DB->get_records('course_categories', array('parent'=>'0'), 'sortorder ASC, id ASC');
} else if (array_key_exists($categoryid, $this->addedcategories)) {
// The category itself has been loaded already so we just need to ensure its subcategories
// have been loaded
@@ -1406,13 +1406,13 @@ protected function load_all_categories($categoryid = null, $showbasecategories =
FROM {course_categories} cc
WHERE (parent = :categoryid OR parent = 0) AND
parent {$sql}
- ORDER BY sortorder";
+ ORDER BY depth DESC, sortorder ASC, id ASC";
} else {
$sql = "SELECT *
FROM {course_categories} cc
WHERE parent = :categoryid AND
parent {$sql}
- ORDER BY sortorder";
+ ORDER BY depth DESC, sortorder ASC, id ASC";
}
$params['categoryid'] = $categoryid;
$categories = $DB->get_records_sql($sql, $params);
@@ -1451,7 +1451,11 @@ protected function load_all_categories($categoryid = null, $showbasecategories =
if (!array_key_exists($catid, $this->addedcategories)) {
// This category isn't in the navigation yet so add it.
$subcategory = $categories[$catid];
- if (array_key_exists($subcategory->parent, $this->addedcategories)) {
+ if ($subcategory->parent == '0') {
+ // Yay we have a root category - this likely means we will now be able
+ // to add categories without problems.
+ $this->add_category($subcategory, $this->rootnodes['courses']);
+ } else if (array_key_exists($subcategory->parent, $this->addedcategories)) {
// The parent is in the category (as we'd expect) so add it now.
$this->add_category($subcategory, $this->addedcategories[$subcategory->parent]);
// Remove the category from the categories array.

0 comments on commit c4afcf8

Please sign in to comment.