Skip to content
Browse files

MDL-34728 forms: woy for other JS to trigger disableIf update.

This was discovered while working on MDL-32705. If some JavaScript (for
example a select all/none link) changes the state of some form fields,
then the disabledIf state of other form elements does not automatically
update.

The existing form JS was so well encapsulated that this was impossible.
This change pokes a hole in the encapsulation, and provides an API
    M.form.updateFormState(formid);
that other bits of JS code can call when necessary.
  • Loading branch information...
1 parent c36de79 commit c9b212083cb1ed50dd2f31b45df7022dd757967c @timhunt timhunt committed
Showing with 20 additions and 3 deletions.
  1. +20 −3 lib/form/form.js
View
23 lib/form/form.js
@@ -59,6 +59,11 @@ M.form.initShowAdvanced = function(Y, config) {
};
/**
+ * Stores a list of the dependencyManager for each form on the page.
+ */
+M.form.dependencyManagers = {};
+
+/**
* Initialises a manager for a forms dependencies.
* This should happen once per form.
*/
@@ -128,7 +133,7 @@ M.form.initFormDependencies = function(Y, formid, dependencies) {
return this.checkDependencies(null);
},
/**
- * Gets all elements in the form by thier name and returns
+ * Gets all elements in the form by their name and returns
* a YUI NodeList
* @return Y.NodeList
*/
@@ -354,5 +359,17 @@ M.form.initFormDependencies = function(Y, formid, dependencies) {
return dependencyManager;
})();
- return new M.form.dependencyManager();
-};
+ M.form.dependencyManagers[formid] = new M.form.dependencyManager();
+ return M.form.dependencyManagers[formid];
+};
+
+/**
+ * Update the state of a form. You need to call this after, for example, changing
+ * the state of some of the form input elements in your own code, in order that
+ * things like the disableIf state of elements can be updated.
+ */
+M.form.updateFormState = function(formid) {
+ if (formid in M.form.dependencyManagers) {
+ M.form.dependencyManagers[formid].checkDependencies(null);
+ }
+};

0 comments on commit c9b2120

Please sign in to comment.
Something went wrong with that request. Please try again.