From cc7ccb6c425be1d12acb74417be7264c9b90a561 Mon Sep 17 00:00:00 2001
From: Laurent David <lmedavid@gmail.com>
Date: Tue, 14 Jun 2022 08:53:56 +0200
Subject: [PATCH] MDL-74821 mod_feedback: Fix HTML validator error

* Remove align attribute on table elements
* Fix dangling tr/td on multichoice rated
* Remove colspan as it is not used
---
 mod/feedback/analysis_course.php                | 2 +-
 mod/feedback/complete.php                       | 2 +-
 mod/feedback/item/info/lib.php                  | 4 ++--
 mod/feedback/item/multichoice/lib.php           | 7 ++++---
 mod/feedback/item/multichoicerated/lib.php      | 9 ++++-----
 mod/feedback/item/numeric/lib.php               | 6 +++---
 mod/feedback/item/textarea/lib.php              | 4 ++--
 mod/feedback/item/textfield/lib.php             | 4 ++--
 mod/feedback/lib.php                            | 2 +-
 mod/feedback/tests/behat/behat_mod_feedback.php | 4 ++--
 10 files changed, 22 insertions(+), 22 deletions(-)

diff --git a/mod/feedback/analysis_course.php b/mod/feedback/analysis_course.php
index 04dfdd7c17023..5cf3ac03b2b94 100644
--- a/mod/feedback/analysis_course.php
+++ b/mod/feedback/analysis_course.php
@@ -119,7 +119,7 @@
 
             echo '<tr>';
             echo '<td>'.$shortname.'</td>';
-            echo '<td align="right">';
+            echo '<td class="text-right">';
             echo format_float(($c->sumvalue / $c->countvalue), 2);
             echo '</td>';
             echo '</tr>';
diff --git a/mod/feedback/complete.php b/mod/feedback/complete.php
index c91b9afd2abd0..c99eda43a01c4 100644
--- a/mod/feedback/complete.php
+++ b/mod/feedback/complete.php
@@ -116,7 +116,7 @@
                     'generalbox boxaligncenter');
         }
         if ($feedbackcompletion->can_view_analysis()) {
-            echo '<p align="center">';
+            echo '<p class="text-center">';
             $analysisurl = new moodle_url('/mod/feedback/analysis.php', array('id' => $cm->id, 'courseid' => $courseid));
             echo html_writer::link($analysisurl, get_string('completed_feedbacks', 'feedback'));
             echo '</p>';
diff --git a/mod/feedback/item/info/lib.php b/mod/feedback/item/info/lib.php
index f1157ec8968c1..3d9d189ef8448 100644
--- a/mod/feedback/item/info/lib.php
+++ b/mod/feedback/item/info/lib.php
@@ -157,7 +157,7 @@ public function print_analysed($item, $itemnr = '', $groupid = false, $courseid
         $analysed_item = $this->get_analysed($item, $groupid, $courseid);
         $data = $analysed_item->data;
         if (is_array($data)) {
-            echo '<tr><th colspan="2" align="left">';
+            echo '<tr><th class="text-left">';
             echo $itemnr . ' ';
             if (strval($item->label) !== '') {
                 echo '('. format_string($item->label).') ';
@@ -167,7 +167,7 @@ public function print_analysed($item, $itemnr = '', $groupid = false, $courseid
             $sizeofdata = count($data);
             for ($i = 0; $i < $sizeofdata; $i++) {
                 $class = strlen(trim($data[$i]->show)) ? '' : ' class="isempty"';
-                echo '<tr'.$class.'><td colspan="2" class="singlevalue">';
+                echo '<tr'.$class.'><td class="singlevalue">';
                 echo str_replace("\n", '<br />', $data[$i]->show);
                 echo '</td></tr>';
             }
diff --git a/mod/feedback/item/multichoice/lib.php b/mod/feedback/item/multichoice/lib.php
index 0c0286be41ce1..cbfb7d00fb8a6 100644
--- a/mod/feedback/item/multichoice/lib.php
+++ b/mod/feedback/item/multichoice/lib.php
@@ -209,14 +209,14 @@ public function print_analysed($item, $itemnr = '', $groupid = false, $courseid
         if ($analysed_item) {
             $itemname = $analysed_item[1];
             echo "<table class=\"analysis itemtype_{$item->typ}\">";
-            echo '<tr><th colspan="2" align="left">';
+            echo '<tr><th class="text-left">';
             echo $itemnr . ' ';
             if (strval($item->label) !== '') {
                 echo '('. format_string($item->label).') ';
             }
             echo format_string($itemname);
             echo '</th></tr>';
-            echo "</table>";
+
             $analysed_vals = $analysed_item[2];
             $count = 0;
             $data = [];
@@ -241,7 +241,8 @@ public function print_analysed($item, $itemnr = '', $groupid = false, $courseid
             $chart->add_series($series);
             $chart->set_labels($data['labels']);
 
-            echo $OUTPUT->render($chart);
+            echo '<tr><td>'. $OUTPUT->render($chart) . '</td></tr>';
+            echo "</table>";
         }
     }
 
diff --git a/mod/feedback/item/multichoicerated/lib.php b/mod/feedback/item/multichoicerated/lib.php
index c2d93be26d538..1c46ed3fa2a65 100644
--- a/mod/feedback/item/multichoicerated/lib.php
+++ b/mod/feedback/item/multichoicerated/lib.php
@@ -180,14 +180,13 @@ public function print_analysed($item, $itemnr = '', $groupid = false, $courseid
         $analysed_item = $this->get_analysed($item, $groupid, $courseid);
         if ($analysed_item) {
             echo "<table class=\"analysis itemtype_{$item->typ}\">";
-            echo '<tr><th colspan="2" align="left">';
+            echo '<tr><th class="text-left">';
             echo $itemnr . ' ';
             if (strval($item->label) !== '') {
                 echo '('. format_string($item->label).') ';
             }
             echo format_string($analysed_item[1]);
             echo '</th></tr>';
-            echo '</table>';
             $analysed_vals = $analysed_item[2];
             $avg = 0.0;
             $count = 0;
@@ -215,12 +214,12 @@ public function print_analysed($item, $itemnr = '', $groupid = false, $courseid
             $series->set_labels($data['series_labels']);
             $chart->add_series($series);
             $chart->set_labels($data['labels']);
-            echo $OUTPUT->render($chart);
-
+            echo '<tr><td>'. $OUTPUT->render($chart) . '</td></tr>';
             $avg = format_float($avg, 2);
-            echo '<tr><td align="left" colspan="2"><b>';
+            echo '<tr><td class="text-left"><b>';
             echo get_string('average', 'feedback').': '.$avg.'</b>';
             echo '</td></tr>';
+            echo '</table>';
         }
     }
 
diff --git a/mod/feedback/item/numeric/lib.php b/mod/feedback/item/numeric/lib.php
index 2d3a340e1cff0..d4afe29966e2d 100644
--- a/mod/feedback/item/numeric/lib.php
+++ b/mod/feedback/item/numeric/lib.php
@@ -144,7 +144,7 @@ public function print_analysed($item, $itemnr = '', $groupid = false, $courseid
 
         if (isset($values->data) AND is_array($values->data)) {
             echo "<table class=\"analysis itemtype_{$item->typ}\">";
-            echo '<tr><th colspan="2" align="left">';
+            echo '<tr><th class="text-left">';
             echo $itemnr . ' ';
             if (strval($item->label) !== '') {
                 echo '('. format_string($item->label).') ';
@@ -153,7 +153,7 @@ public function print_analysed($item, $itemnr = '', $groupid = false, $courseid
             echo '</th></tr>';
 
             foreach ($values->data as $value) {
-                echo '<tr><td colspan="2" class="singlevalue">';
+                echo '<tr><td class="singlevalue">';
                 echo $this->format_float($value);
                 echo '</td></tr>';
             }
@@ -163,7 +163,7 @@ public function print_analysed($item, $itemnr = '', $groupid = false, $courseid
             } else {
                 $avg = '-';
             }
-            echo '<tr><td colspan="2"><b>';
+            echo '<tr><td><b>';
             echo get_string('average', 'feedback').': '.$avg;
             echo '</b></td></tr>';
             echo '</table>';
diff --git a/mod/feedback/item/textarea/lib.php b/mod/feedback/item/textarea/lib.php
index cc3a997fa2a29..cdc09d3b89f7d 100644
--- a/mod/feedback/item/textarea/lib.php
+++ b/mod/feedback/item/textarea/lib.php
@@ -135,7 +135,7 @@ public function print_analysed($item, $itemnr = '', $groupid = false, $courseid
         $values = feedback_get_group_values($item, $groupid, $courseid);
         if ($values) {
             echo "<table class=\"analysis itemtype_{$item->typ}\">";
-            echo '<tr><th colspan="2" align="left">';
+            echo '<tr><th class="text-left">';
             echo $itemnr . ' ';
             if (strval($item->label) !== '') {
                 echo '('. format_string($item->label).') ';
@@ -145,7 +145,7 @@ public function print_analysed($item, $itemnr = '', $groupid = false, $courseid
             foreach ($values as $value) {
                 $class = strlen(trim($value->value)) ? '' : ' class="isempty"';
                 echo '<tr'.$class.'>';
-                echo '<td colspan="2" class="singlevalue">';
+                echo '<td class="singlevalue">';
                 echo str_replace("\n", '<br />', $value->value);
                 echo '</td>';
                 echo '</tr>';
diff --git a/mod/feedback/item/textfield/lib.php b/mod/feedback/item/textfield/lib.php
index c8260ffc909ec..c703ecfb3b94f 100644
--- a/mod/feedback/item/textfield/lib.php
+++ b/mod/feedback/item/textfield/lib.php
@@ -131,7 +131,7 @@ public function print_analysed($item, $itemnr = '', $groupid = false, $courseid
         $values = feedback_get_group_values($item, $groupid, $courseid);
         if ($values) {
             echo "<table class=\"analysis itemtype_{$item->typ}\">";
-            echo '<tr><th colspan="2" align="left">';
+            echo '<tr><th class="text-left">';
             echo $itemnr . ' ';
             if (strval($item->label) !== '') {
                 echo '('. format_string($item->label).') ';
@@ -140,7 +140,7 @@ public function print_analysed($item, $itemnr = '', $groupid = false, $courseid
             echo '</th></tr>';
             foreach ($values as $value) {
                 $class = strlen(trim($value->value)) ? '' : ' class="isempty"';
-                echo '<tr'.$class.'><td colspan="2" class="singlevalue">';
+                echo '<tr'.$class.'><td class="singlevalue">';
                 echo str_replace("\n", '<br />', $value->value);
                 echo '</td></tr>';
             }
diff --git a/mod/feedback/lib.php b/mod/feedback/lib.php
index 417bb1d7cc573..17929a260fcf5 100644
--- a/mod/feedback/lib.php
+++ b/mod/feedback/lib.php
@@ -488,7 +488,7 @@ function feedback_print_recent_mod_activity($activity, $courseid, $detail, $modn
 
     echo '<table border="0" cellpadding="3" cellspacing="0" class="forum-recent">';
 
-    echo "<tr><td class=\"userpicture\" valign=\"top\">";
+    echo "<tr><td class=\"userpicture align-top\">";
     echo $OUTPUT->user_picture($activity->user, array('courseid'=>$courseid));
     echo "</td><td>";
 
diff --git a/mod/feedback/tests/behat/behat_mod_feedback.php b/mod/feedback/tests/behat/behat_mod_feedback.php
index 43e74ea8964ad..f2916fbd399b2 100644
--- a/mod/feedback/tests/behat/behat_mod_feedback.php
+++ b/mod/feedback/tests/behat/behat_mod_feedback.php
@@ -153,8 +153,8 @@ function($context, $args) use ($behatgeneralcontext) {
      */
     public function i_show_chart_data_for_the_feedback($feedbackname) {
 
-        $feedbackxpath = "//th[contains(normalize-space(string(.)), \"" . $feedbackname . "\")]/ancestor::table/" .
-            "following-sibling::div[contains(concat(' ', normalize-space(@class), ' '), ' chart-area ')][1]" .
+        $feedbackxpath = "//th[contains(normalize-space(string(.)), \"" . $feedbackname . "\")]/ancestor::table//" .
+            "div[contains(concat(' ', normalize-space(@class), ' '), ' chart-table ')]" .
             "//p[contains(concat(' ', normalize-space(@class), ' '), ' chart-table-expand ') and ".
             "//a[contains(normalize-space(string(.)), '".get_string('showchartdata')."')]]";