Browse files

MDL-5262 - PHP notice when sorting on R% coloumn in the Item analysis…

… report - I adopted the simple solution of stopping people sorting on that column, since it is the same as sorting on rcount, I think. Backported from MOODLE_19_STABLE.
  • Loading branch information...
1 parent c6a1029 commit d01b47381b79eef698a7a050cf5d060ac552a45f tjhunt committed Oct 16, 2007
Showing with 3 additions and 2 deletions.
  1. +3 −2 mod/quiz/report/analysis/report.php
View
5 mod/quiz/report/analysis/report.php
@@ -87,8 +87,8 @@ function display($quiz, $cm, $course) { /// This function just displays the
}
$sql .= ' WHERE qa.quiz = '.$quiz->id. // ULPGC ecastro
' AND ( qa.sumgrades >= '.$scorelimit.' ) ';
- // ^^^^^^ es posible seleccionar aqu TODOS los quizzes, como quiere Jussi,
- // pero habr�a que llevar la cuenta ed cada quiz para restaura las preguntas (quizquestions, states)
+ // ^^^^^^ es posible seleccionar aqu TODOS los quizzes, como quiere Jussi,
+ // pero habra que llevar la cuenta ed cada quiz para restaura las preguntas (quizquestions, states)
/// Fetch the attempts
$attempts = get_records_sql($sql);
@@ -244,6 +244,7 @@ function display($quiz, $cm, $course) { /// This function just displays the
$table->define_baseurl($CFG->wwwroot.'/mod/quiz/report.php?q='.$quiz->id.'&mode=analysis');
$table->sortable(true);
+ $table->no_sorting('rpercent');
$table->collapsible(true);
$table->initialbars(false);

0 comments on commit d01b473

Please sign in to comment.