Skip to content
Browse files

MDL-31360 Don't use get_in_or_equal if array is empty, tidy up struct…

…ure of $extracaps array
  • Loading branch information...
1 parent 216f6d8 commit d14c00e239c6b2e90ca9c7c1af76ebefee5acb2e @danmarsden danmarsden committed
Showing with 8 additions and 8 deletions.
  1. +8 −8 lib/accesslib.php
View
16 lib/accesslib.php
@@ -6380,6 +6380,7 @@ public function get_capabilities() {
}
$modfile = "$CFG->dirroot/mod/$module->name/lib.php";
+ $extracaps = array();
if (file_exists($modfile)) {
include_once($modfile);
$modfunction = $module->name.'_get_extra_capabilities';
@@ -6387,16 +6388,15 @@ public function get_capabilities() {
$extracaps = $modfunction();
}
}
- if (empty($extracaps)) {
- $extracaps = array();
- }
$extracaps = array_merge($subcaps, $extracaps);
-
- list($extra, $params) = $DB->get_in_or_equal(
- $extracaps, SQL_PARAMS_NAMED, 'cap0');
- $extra = "OR name $extra";
-
+ $extra = '';
+ $params = array();
+ if (!empty($extracaps)) {
+ list($extra, $params) = $DB->get_in_or_equal(
+ $extracaps, SQL_PARAMS_NAMED, 'cap0');
+ $extra = "OR name $extra";
+ }
$sql = "SELECT *
FROM {capabilities}
WHERE (contextlevel = ".CONTEXT_MODULE."

0 comments on commit d14c00e

Please sign in to comment.
Something went wrong with that request. Please try again.