Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

MDL-37714: Correctly identify frequently used comments during restore

  • Loading branch information...
commit d291a6fddddeccd193ebc5038be25f010165ec37 1 parent 953239d
@greg-or greg-or authored
View
2  grade/grading/form/guide/backup/moodle2/backup_gradingform_guide_plugin.class.php
@@ -65,7 +65,7 @@ protected function define_definition_plugin_structure() {
$pluginwrapper->add_child($criteria);
$criteria->add_child($criterion);
- $criteria->add_child($comments);
+ $pluginwrapper->add_child($comments);
$comments->add_child($comment);
// Set sources to populate the data.
View
19 grade/grading/form/guide/backup/moodle2/restore_gradingform_guide_plugin.class.php
@@ -48,6 +48,11 @@ protected function define_definition_plugin_structure() {
$paths[] = new restore_path_element('gradingform_guide_comment',
$this->get_pathfor('/guidecomments/guidecomment'));
+ // MDL-37714: Correctly locate frequent used comments in both the
+ // current and incorrect old format.
+ $paths[] = new restore_path_element('gradingform_guide_comment_legacy',
+ $this->get_pathfor('/guidecriteria/guidecomments/guidecomment'));
+
return $paths;
}
@@ -100,6 +105,20 @@ public function process_gradingform_guide_comment($data) {
}
/**
+ * Processes comments element data
+ *
+ * @param array|stdClass $data The data to insert as a comment
+ */
+ public function process_gradingform_guide_comment_legacy($data) {
+ global $DB;
+
+ $data = (object)$data;
+ $data->definitionid = $this->get_new_parentid('grading_definition');
+
+ $DB->insert_record('gradingform_guide_comments', $data);
+ }
+
+ /**
* Processes filling element data
*
* @param array|stdClass $data The data to insert as a filling
Please sign in to comment.
Something went wrong with that request. Please try again.