Permalink
Browse files

MDL-38373 Use correct PEAR->loadExtension()

Current use is wrong (static) and leads to strict standards notice.
  • Loading branch information...
1 parent d43ba3c commit d312ce89e29286be9af5cdb3ddf1192709aaa98c @stronk7 stronk7 committed Mar 7, 2013
Showing with 8 additions and 1 deletion.
  1. +2 −1 lib/pear/Auth/RADIUS.php
  2. +6 −0 lib/pear/README_MOODLE.txt
View
3 lib/pear/Auth/RADIUS.php
@@ -46,7 +46,7 @@
* @version $Revision$
*/
-PEAR::loadExtension('radius');
+// PEAR::loadExtension('radius'); // Moodle commented. See MDL-38373.
/**
* class Auth_RADIUS
@@ -127,6 +127,7 @@ class Auth_RADIUS extends PEAR {
*/
function Auth_RADIUS()
{
+ $this->loadExtension('radius'); // Moodle added. See MDL-38373.
$this->PEAR();
}
View
6 lib/pear/README_MOODLE.txt
@@ -1,6 +1,12 @@
MOODLE-SPECIFIC PEAR MODIFICATIONS
==================================
+Auth/RADIUS
+===========
+
+1/ Changed static call to correct alternative (MDL-38373):
+ - From: PEAR::loadExtension('radius'); (in global scope)
+ - To: $this->loadExtension('radius'); (in constructor)
Spreadsheet/Excel
=================

0 comments on commit d312ce8

Please sign in to comment.