Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

MDL-33681 course: cannot have a section called '0'.

No reason to prevent this. It is just a matter of doing a proper test,
rather than the sloppy PHP !empty().
  • Loading branch information...
commit d375d718acf6da7d22359c448dda572d803e309c 1 parent 4776262
@timhunt timhunt authored
Showing with 2 additions and 2 deletions.
  1. +1 −1  course/format/topics/lib.php
  2. +1 −1  course/format/weeks/lib.php
View
2  course/format/topics/lib.php
@@ -69,7 +69,7 @@ function callback_topics_request_key() {
function callback_topics_get_section_name($course, $section) {
// We can't add a node without any text
- if (!empty($section->name)) {
+ if ((string)$section->name !== '') {
return format_string($section->name, true, array('context' => get_context_instance(CONTEXT_COURSE, $course->id)));
} else if ($section->section == 0) {
return get_string('section0name', 'format_topics');
View
2  course/format/weeks/lib.php
@@ -76,7 +76,7 @@ function callback_weeks_request_key() {
*/
function callback_weeks_get_section_name($course, $section) {
// We can't add a node without text
- if (!empty($section->name)) {
+ if ((string)$section->name !== '') {
// Return the name the user set
return format_string($section->name, true, array('context' => get_context_instance(CONTEXT_COURSE, $course->id)));
} else if ($section->section == 0) {
Please sign in to comment.
Something went wrong with that request. Please try again.