MDL-29733 grade: Query for Identifying Grade Grades to Precreate is SLOW

moodle · Oct 30, 2012 · d557253 · d557253
1 parent 67ba008
commit d557253
Showing 1 changed file with 20 additions and 10 deletions.
diff --git a/lib/grade/grade_item.php b/lib/grade/grade_item.php
@@ -1670,16 +1670,26 @@ public function compute($userid=null) {
             return true; // no need to recalculate locked items
         }
 
-        // precreate grades - we need them to exist
+        if ($userid) {
-        $params = array($this->courseid, $this->id, $this->id);
+            $missing = array();
-        $sql = "SELECT DISTINCT go.userid
+            if (!$DB->record_exists('grade_grades', array('itemid'=>$this->id, 'userid'=>$userid))) {
-                  FROM {grade_grades} go
+                $m = new stdClass();
-                       JOIN {grade_items} gi
+                $m->userid = $userid;
-                       ON (gi.id = go.itemid AND gi.courseid = ?)
+                $missing[] = $m;
-                       LEFT OUTER JOIN {grade_grades} g
+            }
-                       ON (g.userid = go.userid AND g.itemid = ?)
+        } else {
-                 WHERE gi.id <> ? AND g.id IS NULL";
+            // precreate grades - we need them to exist
-        if ($missing = $DB->get_records_sql($sql, $params)) {
+            $params = array($this->courseid, $this->id);
+            $sql = "SELECT go.userid
+                      FROM {grade_grades} go
+                           JOIN {grade_items} gi
+                           ON (gi.id = go.itemid AND gi.courseid = ?)
+                     GROUP BY go.userid
+                     HAVING SUM(go.itemid = ?) = 0";
+            $missing = $DB->get_records_sql($sql, $params);
+        }
+
+        if ($missing) {
             foreach ($missing as $m) {
                 $grade = new grade_grade(array('itemid'=>$this->id, 'userid'=>$m->userid), false);
                 $grade->grade_item =& $this;