diff --git a/completion/criteria/completion_criteria_activity.php b/completion/criteria/completion_criteria_activity.php index 4fa66b536b638..c64805e01cfc3 100644 --- a/completion/criteria/completion_criteria_activity.php +++ b/completion/criteria/completion_criteria_activity.php @@ -60,7 +60,11 @@ public static function fetch($params) { * @param stdClass $data details of various modules */ public function config_form_display(&$mform, $data = null) { - $mform->addElement('checkbox', 'criteria_activity['.$data->id.']', ucfirst(self::get_mod_name($data->module)).' - '.$data->name); + $modnames = get_module_types_names(); + $mform->addElement('checkbox', 'criteria_activity['.$data->id.']', + $modnames[self::get_mod_name($data->module)]. + ' - '. + format_string($data->name)); if ($this->id) { $mform->setDefault('criteria_activity['.$data->id.']', 1); @@ -177,7 +181,8 @@ public function get_title_detailed() { $module = $DB->get_record('course_modules', array('id' => $this->moduleinstance)); $activity = $DB->get_record($this->module, array('id' => $module->instance)); - return shorten_text(urldecode($activity->name)); + return shorten_text(format_string($activity->name, true, + array('context' => context_module::instance($module->id)))); } /** diff --git a/report/completion/index.php b/report/completion/index.php index 5f84c2669524c..0791018ac9652 100644 --- a/report/completion/index.php +++ b/report/completion/index.php @@ -468,7 +468,7 @@ // Display icon $icon = $OUTPUT->pix_url('icon', $criterion->module); $iconlink = $CFG->wwwroot.'/mod/'.$criterion->module.'/view.php?id='.$criterion->moduleinstance; - $icontitle = $modinfo->cms[$criterion->moduleinstance]->name; + $icontitle = $modinfo->cms[$criterion->moduleinstance]->get_formatted_name(); $iconalt = get_string('modulename', $criterion->module); break; @@ -532,8 +532,9 @@ // Load activity $mod = $criterion->get_mod_instance(); - $row[] = $mod->name; - $row[] = $mod->name . ' - ' . get_string('completiondate', 'report_completion'); + $row[] = $formattedname = format_string($mod->name, true, + array('context' => context_module::instance($criterion->moduleinstance))); + $row[] = $formattedname . ' - ' . get_string('completiondate', 'report_completion'); } else { // Handle all other criteria @@ -616,7 +617,7 @@ $a->state = $describe; $a->date = $date; $a->user = fullname($user); - $a->activity = strip_tags($activity->name); + $a->activity = $activity->get_formatted_name(); $fulldescribe = get_string('progress-title', 'completion', $a); if ($csv) { @@ -626,7 +627,7 @@ print '