Permalink
Browse files

MDL-50788 classloader: Prevent cryptic errors on unreadable classes dir

Do not attempt to read an unreadable directory because previously the generated
errors were hard to fathom.

Thanks to James McQuillan for the basis of the patch.
  • Loading branch information...
danpoltawski committed Oct 9, 2015
1 parent 6d8dbfe commit d6e6b308c573585072d61a0cc12d6901435c6fea
Showing with 7 additions and 0 deletions.
  1. +7 −0 lib/classes/component.php
@@ -647,6 +647,13 @@ protected static function load_classes($component, $fulldir, $namespace = '') {
return;
}
if (!is_readable($fulldir)) {
// TODO: MDL-51711 We should generate some diagnostic debugging information in this case
// because its pretty likely to lead to a missing class error further down the line.
// But our early setup code can't handle errors this early at the moment.
return;
}
$items = new \DirectoryIterator($fulldir);
foreach ($items as $item) {
if ($item->isDot()) {

0 comments on commit d6e6b30

Please sign in to comment.