MDL-64818 blocks: blocks_for_region() is inefficient.

moodle · Aug 7, 2020 · da4ded8 · da4ded8
1 parent a7d9b53
commit da4ded8
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/outputrenderers.php b/lib/outputrenderers.php
@@ -1817,11 +1817,12 @@ public function list_block_contents($icons, $items) {
      */
     public function blocks_for_region($region) {
         $blockcontents = $this->page->blocks->get_content_for_region($region, $this);
-        $blocks = $this->page->blocks->get_blocks_for_region($region);
         $lastblock = null;
         $zones = array();
-        foreach ($blocks as $block) {
-            $zones[] = $block->title;
+        foreach ($blockcontents as $bc) {
+            if ($bc instanceof block_contents) {
+                $zones[] = $bc->title;
+            }
         }
         $output = '';