Skip to content

Commit

Permalink
MDL-36767 Administration: user_filter_yesno use different name for sq…
Browse files Browse the repository at this point in the history
…l filter

user_filter_yesno extends user_filter_simpleselect, so if user bulk action filter has both
user_filter_simpleselect and user_filter_yesno, they use the same filter name but counter is
different as they are different classes. Hence using different filter name will avoid confilts
  • Loading branch information
Rajesh Taneja committed Nov 27, 2012
1 parent 5f1d8f2 commit e006de4
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions user/filters/yesno.php
Expand Up @@ -15,4 +15,22 @@ class user_filter_yesno extends user_filter_simpleselect {
function user_filter_yesno($name, $label, $advanced, $field) {
parent::user_filter_simpleselect($name, $label, $advanced, $field, array(0=>get_string('no'), 1=>get_string('yes')));
}

/**
* Returns the condition to be used with SQL
*
* @param array $data filter settings
* @return array sql string and $params
*/
function get_sql_filter($data) {
static $counter = 0;
$name = 'ex_yesno'.$counter++;

$value = $data['value'];
$field = $this->_field;
if ($value == '') {
return array();
}
return array("$field=:$name", array($name => $value));
}
}

0 comments on commit e006de4

Please sign in to comment.