Permalink
Browse files

MDL-31708 wiki: Wiki 2.0 non-group member can see edit option in navi…

…gation block
  • Loading branch information...
1 parent b1c5155 commit e2694e9dd6089856a14b62ddebc1a0de5b06783d @leblangi leblangi committed Oct 18, 2012
Showing with 6 additions and 11 deletions.
  1. +2 −0 mod/wiki/lang/en/wiki.php
  2. +1 −1 mod/wiki/lib.php
  3. +1 −1 mod/wiki/locallib.php
  4. +2 −9 mod/wiki/pagelib.php
View
2 mod/wiki/lang/en/wiki.php
@@ -22,8 +22,10 @@
$string['backpage'] = 'Back to page';
$string['backtomapmenu'] = 'Back to map menu';
$string['changerate'] = 'Do you wish to change it?';
+$string['cannoteditpage'] = 'You can not edit this page.';
$string['cannotmanagefiles'] = 'You don\'t have permission to manage the wiki files.';
$string['cannotviewfiles'] = 'You don\'t have permission to view the wiki files.';
+$string['cannotviewpage'] = 'You can not view this page.';
$string['comparesel'] = 'Compare selected';
$string['comments'] = 'Comments';
$string['commentscount'] = 'Comments ({$a})';
View
2 mod/wiki/lib.php
@@ -531,7 +531,7 @@ function wiki_extend_navigation(navigation_node $navref, $course, $module, $cm)
$node = $navref->add(get_string('view', 'wiki'), $link, navigation_node::TYPE_SETTING);
}
- if (has_capability('mod/wiki:editpage', $context)) {
+ if (wiki_user_can_edit($subwiki)) {
$link = new moodle_url('/mod/wiki/edit.php', array('pageid' => $pageid));
$node = $navref->add(get_string('edit', 'wiki'), $link, navigation_node::TYPE_SETTING);
}
View
2 mod/wiki/locallib.php
@@ -767,7 +767,7 @@ function wiki_user_can_view($subwiki) {
// Each person owns a wiki.
if ($wiki->wikimode == 'collaborative' || $wiki->wikimode == 'individual') {
// Only members of subwiki group could view that wiki
- if ($subwiki->groupid == groups_get_activity_group($cm)) {
+ if (groups_is_member($subwiki->groupid)) {
// Only view capability needed
return has_capability('mod/wiki:viewpage', $context);
View
11 mod/wiki/pagelib.php
@@ -172,13 +172,8 @@ protected function setup_tabs($options = array()) {
if (!$manage and !($edit and groups_is_member($currentgroup))) {
unset($this->tabs['edit']);
}
- } else {
- if (!has_capability('mod/wiki:editpage', $PAGE->context)) {
- unset($this->tabs['edit']);
- }
}
-
if (empty($options)) {
$this->tabs_options = array('activetab' => substr(get_class($this), 10));
} else {
@@ -326,8 +321,7 @@ function print_content() {
}
}
} else {
- // @TODO: Tranlate it
- echo "You can not view this page";
+ echo get_string('cannotviewpage', 'wiki');
}
}
@@ -420,8 +414,7 @@ function print_content() {
if (wiki_user_can_edit($this->subwiki)) {
$this->print_edit();
} else {
- // @TODO: Translate it
- echo "You can not edit this page";
+ echo get_string('cannoteditpage', 'wiki');
}
}

0 comments on commit e2694e9

Please sign in to comment.