Permalink
Browse files

MDL-33863 question restore: better hint identification.

This is very similar to what MDL-30018 did for question_answers.
  • Loading branch information...
1 parent 6548ce0 commit e2ba9a1d70a6c822f81b72b68ca39f84ddb882a8 Jean-Michel Vedrine committed with timhunt Nov 19, 2012
Showing with 16 additions and 0 deletions.
  1. +16 −0 backup/moodle2/restore_stepslib.php
View
16 backup/moodle2/restore_stepslib.php
@@ -2960,6 +2960,22 @@ protected function process_question_hint($data) {
AND ' . $DB->sql_compare_text('hint', 255) . ' = ' . $DB->sql_compare_text('?', 255);
$params = array($newquestionid, $data->hint);
$newitemid = $DB->get_field_sql($sql, $params);
+
+ // Not able to find the hint, let's try cleaning the hint text
+ // of all the question's hints in DB as slower fallback. MDL-33863.
+ if (!$newitemid) {
+ $potentialhints = $DB->get_records('question_hints',
+ array('questionid' => $newquestionid), '', 'id, hint');
+ foreach ($potentialhints as $potentialhint) {
+ // Clean in the same way than {@link xml_writer::xml_safe_utf8()}.
+ $cleanhint = preg_replace('/[\x-\x8\xb-\xc\xe-\x1f\x7f]/is','', $potentialhint->hint); // Clean CTRL chars.
+ $cleanhint = preg_replace("/\r\n|\r/", "\n", $cleanhint); // Normalize line ending.
+ if ($cleanhint === $data->hint) {
+ $newitemid = $data->id;
+ }
+ }
+ }
+
// If we haven't found the newitemid, something has gone really wrong, question in DB
// is missing hints, exception
if (!$newitemid) {

0 comments on commit e2ba9a1

Please sign in to comment.