Permalink
Browse files

MDL-35767 Fix missing target event group check

Prevent interfering between items from different groups (and no groups)
  • Loading branch information...
1 parent 9273bd1 commit e6b958d4db4ff8c938f5b867b50073f1128a8bb7 @kabalin kabalin committed Oct 3, 2012
Showing with 4 additions and 0 deletions.
  1. +4 −0 lib/yui/dragdrop/dragdrop.js
View
4 lib/yui/dragdrop/dragdrop.js
@@ -167,6 +167,10 @@ YUI.add('moodle-core-dragdrop', function(Y) {
// this.lastdroptarget (ghost node we use for indicating where to drop)
e.drag = e.target;
e.drop = this.lastdroptarget;
+ // Check that drag object belongs to correct group
+ if (!this.in_group(e.drag)) {
+ return;
+ }
// Check that drop object belong to correct group
if (!e.drop || !e.drop.inGroup(this.groups)) {
return;

0 comments on commit e6b958d

Please sign in to comment.