From e85a54d931807e8eb407fac8024fd3877579332e Mon Sep 17 00:00:00 2001
From: "Eloy Lafuente (stronk7)" <stronk7@moodle.org>
Date: Thu, 8 Mar 2012 12:27:44 +0100
Subject: [PATCH] MDL-31248 - lib - Gah, erroneus condition fixed.

For sure that leaded to accept anything as valid username
for cookies in 19_STABLE. That explains why garbled username were
being transformed into "invented" usernames, instead of blank.
---
 lib/moodlelib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/moodlelib.php b/lib/moodlelib.php
index 981b0ed478a04..fb7ebc3b96fc5 100644
--- a/lib/moodlelib.php
+++ b/lib/moodlelib.php
@@ -2771,7 +2771,7 @@ function get_moodle_cookie() {
             $username = rc4decrypt($_COOKIE[$cookiename]);
             $userdata = moodle_strtolower($username);
             $userdata = preg_replace('/[^-\.@_a-z0-9]/', '', $userdata);
-            if ($userdata == $userdata) {
+            if ($username == $userdata) {
                 set_moodle_cookie($username);
             } else {
                 $username = '';