Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

MDL-29534 Forum: Fixed userfrom reference problem

  • Loading branch information...
commit e9c55e3993848d9a62bfd26921cc790de987a97e 1 parent a7a1e05
@rajeshtaneja rajeshtaneja authored
Showing with 8 additions and 5 deletions.
  1. +8 −5 mod/forum/lib.php
View
13 mod/forum/lib.php
@@ -705,6 +705,14 @@ function forum_cron() {
$eventdata->fullmessagehtml = $posthtml;
$eventdata->notification = 1;
+ // If forum_replytouser is not set then send mail using the noreplyaddress.
+ if (empty($CFG->forum_replytouser)) {
+ // Clone userfrom as it is referenced by $users.
+ $cloneduserfrom = clone($userfrom);
+ $cloneduserfrom->email = $CFG->noreplyaddress;
+ $eventdata->userfrom = $cloneduserfrom;
+ }
+
$smallmessagestrings = new stdClass();
$smallmessagestrings->user = fullname($userfrom);
$smallmessagestrings->forumname = "$shortname: ".format_string($forum->name,true).": ".$discussion->name;
@@ -715,11 +723,6 @@ function forum_cron() {
$eventdata->contexturl = "{$CFG->wwwroot}/mod/forum/discuss.php?d={$discussion->id}#p{$post->id}";
$eventdata->contexturlname = $discussion->name;
- // If forum_replytouser is not set then send mail using the noreplyaddress.
- if (empty($CFG->forum_replytouser)) {
- $eventdata->userfrom->email = $CFG->noreplyaddress;
- }
-
$mailresult = message_send($eventdata);
if (!$mailresult){
mtrace("Error: mod/forum/lib.php forum_cron(): Could not send out mail for id $post->id to user $userto->id".
Please sign in to comment.
Something went wrong with that request. Please try again.