From 90e0c511b1c23b29a0e4e286988b08c3935dde01 Mon Sep 17 00:00:00 2001 From: Marina Glancy Date: Wed, 4 Dec 2013 18:27:55 +1100 Subject: [PATCH] MDL-40191 folder: Do not check capability in renderer Capability to access the module is already checked before calling the renderer. Extra check works bad together with switching roles --- mod/folder/renderer.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/mod/folder/renderer.php b/mod/folder/renderer.php index 07c0f63ed7e75..c0faeb1f8a7a4 100644 --- a/mod/folder/renderer.php +++ b/mod/folder/renderer.php @@ -40,11 +40,10 @@ public function display_folder(stdClass $folder) { $folderinstances = get_fast_modinfo($folder->course)->get_instances_of('folder'); if (!isset($folderinstances[$folder->id]) || !($cm = $folderinstances[$folder->id]) || - !$cm->uservisible || - !($context = context_module::instance($cm->id)) || - !has_capability('mod/folder:view', $context)) { - // some error in parameters or module is not visible to the user - // don't throw any errors in renderer, just return empty string + !($context = context_module::instance($cm->id))) { + // Some error in parameters. + // Don't throw any errors in renderer, just return empty string. + // Capability to view module must be checked before calling renderer. return $output; }