Merge branch 'MDL-61990' of https://github.com/timhunt/moodle

David Monllao · David Monllao · commit f2d83f50e155 · 2018-11-14T12:09:34.000+01:00
diff --git a/lib/outputrequirementslib.php b/lib/outputrequirementslib.php
@@ -1023,7 +1023,9 @@ public function js_call_amd($fullmodule, $func, $params = array()) {
         if ($CFG->debugdeveloper) {
             $toomanyparamslimit = 1024;
             if (strlen($strparams) > $toomanyparamslimit) {
-                debugging('Too many params passed to js_call_amd("' . $fullmodule . '", "' . $func . '")', DEBUG_DEVELOPER);
+                debugging('Too much data passed as arguments to js_call_amd("' . $fullmodule . '", "' . $func .
+                        '"). Generally there are better ways to pass lots of data from PHP to JavaScript, for example via Ajax, data attributes, ... . ' .
+                        'This warning is triggered if the argument string becomes longer than ' . $toomanyparamslimit . ' characters.', DEBUG_DEVELOPER);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1023,7 +1023,9 @@ public function js_call_amd($fullmodule, $func, $params = array()) {`
`1023`	`1023`	`if ($CFG->debugdeveloper) {`
`1024`	`1024`	`$toomanyparamslimit = 1024;`
`1025`	`1025`	`if (strlen($strparams) > $toomanyparamslimit) {`
`1026`		`- debugging('Too many params passed to js_call_amd("' . $fullmodule . '", "' . $func . '")', DEBUG_DEVELOPER);`
	`1026`	`+ debugging('Too much data passed as arguments to js_call_amd("' . $fullmodule . '", "' . $func .`
	`1027`	`+ '"). Generally there are better ways to pass lots of data from PHP to JavaScript, for example via Ajax, data attributes, ... . ' .`
	`1028`	`+ 'This warning is triggered if the argument string becomes longer than ' . $toomanyparamslimit . ' characters.', DEBUG_DEVELOPER);`
`1027`	`1029`	`}`
`1028`	`1030`	`}`
`1029`	`1031`