Permalink
Browse files

MDL-28603 - fix regression for SCORM 1.2 test

  • Loading branch information...
1 parent 7969f1e commit f35b5884befabde5d69fbb85806b461a70b6b025 @danmarsden danmarsden committed Aug 12, 2011
Showing with 3 additions and 6 deletions.
  1. +3 −6 mod/scorm/locallib.php
View
@@ -1288,9 +1288,6 @@ function scorm_get_toc($user,$scorm,$cmid,$toclink=TOCJSLINK,$currentorg='',$sco
$usertracks = array();
foreach ($scoes as $sco) {
if (!empty($sco->launch)) {
- if (empty($scoid)) {
- $scoid = $sco->id;
- }
if ($usertrack = scorm_get_tracks($sco->id,$user->id,$attempt)) {
if ($usertrack->status == '') {
$usertrack->status = 'notattempted';
@@ -1464,10 +1461,10 @@ function scorm_get_toc($user,$scorm,$cmid,$toclink=TOCJSLINK,$currentorg='',$sco
}
if ($play) {
- if (empty($scoid)) {
- $scoid = reset($scoes)->id;
+ // it is possible that $scoid is still not set, in this case we don't want an empty object
+ if ($scoid) {
+ $sco = scorm_get_sco($scoid);
}
- $sco = scorm_get_sco($scoid);
$sco->previd = $previd;
$sco->nextid = $nextid;
$result->sco = $sco;

0 comments on commit f35b588

Please sign in to comment.