Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

MDL-33780 question import: strip UTF8 BOM

Previously, if there was a byte-order mark at the start of the file, the
import would just break, which was silly. Much better to just strip it
off.
  • Loading branch information...
commit f4bd9d38a6899354616a182bbbc74eb358710fe1 1 parent 68b0cae
Tim Hunt timhunt authored
Showing with 4 additions and 1 deletion.
  1. +4 −1 question/format.php
5 question/format.php
View
@@ -539,7 +539,10 @@ protected function readdata($filename) {
if (is_readable($filename)) {
$filearray = file($filename);
- /// Check for Macintosh OS line returns (ie file on one line), and fix
+ // If the first line of the file starts with a UTF-8 BOM, remove it.
+ $filearray[0] = textlib::trim_utf8_bom($filearray[0]);
+
+ // Check for Macintosh OS line returns (ie file on one line), and fix.
if (preg_match("~\r~", $filearray[0]) AND !preg_match("~\n~", $filearray[0])) {
return explode("\r", $filearray[0]);
} else {
Please sign in to comment.
Something went wrong with that request. Please try again.