From f788c16f002b3a72b34662f28e8b5e89c7bbb74c Mon Sep 17 00:00:00 2001 From: Dan Poltawski Date: Fri, 27 Nov 2015 14:00:14 +0000 Subject: [PATCH] MDL-51719 atto_rtl: RTL/LTR buttons now indicate state Previously the RTL buttons did not indiciate wether RTL or LTR was selected. Thanks to Andrew Nicols for guiding how to do this. --- .../moodle-atto_rtl-button/moodle-atto_rtl-button-debug.js | 6 ++++-- .../moodle-atto_rtl-button/moodle-atto_rtl-button-min.js | 2 +- .../build/moodle-atto_rtl-button/moodle-atto_rtl-button.js | 6 ++++-- lib/editor/atto/plugins/rtl/yui/src/button/js/button.js | 6 ++++-- 4 files changed, 13 insertions(+), 7 deletions(-) diff --git a/lib/editor/atto/plugins/rtl/yui/build/moodle-atto_rtl-button/moodle-atto_rtl-button-debug.js b/lib/editor/atto/plugins/rtl/yui/build/moodle-atto_rtl-button/moodle-atto_rtl-button-debug.js index ba14c132c16d0..674bc25b82986 100644 --- a/lib/editor/atto/plugins/rtl/yui/build/moodle-atto_rtl-button/moodle-atto_rtl-button-debug.js +++ b/lib/editor/atto/plugins/rtl/yui/build/moodle-atto_rtl-button/moodle-atto_rtl-button-debug.js @@ -43,7 +43,8 @@ Y.namespace('M.atto_rtl').Button = Y.Base.create('button', Y.M.editor_atto.Edito title: direction, buttonName: direction, callback: this._toggleRTL, - callbackArgs: direction + callbackArgs: direction, + tags: '[dir=ltr]' }); direction = 'rtl'; @@ -52,7 +53,8 @@ Y.namespace('M.atto_rtl').Button = Y.Base.create('button', Y.M.editor_atto.Edito title: direction, buttonName: direction, callback: this._toggleRTL, - callbackArgs: direction + callbackArgs: direction, + tags: '[dir=rtl]' }); }, diff --git a/lib/editor/atto/plugins/rtl/yui/build/moodle-atto_rtl-button/moodle-atto_rtl-button-min.js b/lib/editor/atto/plugins/rtl/yui/build/moodle-atto_rtl-button/moodle-atto_rtl-button-min.js index 51d0be479a8b5..8c93865c56223 100644 --- a/lib/editor/atto/plugins/rtl/yui/build/moodle-atto_rtl-button/moodle-atto_rtl-button-min.js +++ b/lib/editor/atto/plugins/rtl/yui/build/moodle-atto_rtl-button/moodle-atto_rtl-button-min.js @@ -1 +1 @@ -YUI.add("moodle-atto_rtl-button",function(e,t){e.namespace("M.atto_rtl").Button=e.Base.create("button",e.M.editor_atto.EditorPlugin,[],{initializer:function(){var e;e="ltr",this.addButton({icon:"e/left_to_right",title:e,buttonName:e,callback:this._toggleRTL,callbackArgs:e}),e="rtl",this.addButton({icon:"e/right_to_left",title:e,buttonName:e,callback:this._toggleRTL,callbackArgs:e})},_toggleRTL:function(e,t){var n=this.get("host"),r=rangy.saveSelection(),i=n.getSelection(),s={rtl:"ltr",ltr:"rtl"};if(i){var o=n.formatSelectionBlock(),u=o.getDOMNode(),a=u.getAttribute("dir");a===t?u.setAttribute("dir",s[t]):u.setAttribute("dir",t),rangy.restoreSelection(r),this.markUpdated()}}})},"@VERSION@",{requires:["moodle-editor_atto-plugin"]}); +YUI.add("moodle-atto_rtl-button",function(e,t){e.namespace("M.atto_rtl").Button=e.Base.create("button",e.M.editor_atto.EditorPlugin,[],{initializer:function(){var e;e="ltr",this.addButton({icon:"e/left_to_right",title:e,buttonName:e,callback:this._toggleRTL,callbackArgs:e,tags:"[dir=ltr]"}),e="rtl",this.addButton({icon:"e/right_to_left",title:e,buttonName:e,callback:this._toggleRTL,callbackArgs:e,tags:"[dir=rtl]"})},_toggleRTL:function(e,t){var n=this.get("host"),r=rangy.saveSelection(),i=n.getSelection(),s={rtl:"ltr",ltr:"rtl"};if(i){var o=n.formatSelectionBlock(),u=o.getDOMNode(),a=u.getAttribute("dir");a===t?u.setAttribute("dir",s[t]):u.setAttribute("dir",t),rangy.restoreSelection(r),this.markUpdated()}}})},"@VERSION@",{requires:["moodle-editor_atto-plugin"]}); diff --git a/lib/editor/atto/plugins/rtl/yui/build/moodle-atto_rtl-button/moodle-atto_rtl-button.js b/lib/editor/atto/plugins/rtl/yui/build/moodle-atto_rtl-button/moodle-atto_rtl-button.js index ba14c132c16d0..674bc25b82986 100644 --- a/lib/editor/atto/plugins/rtl/yui/build/moodle-atto_rtl-button/moodle-atto_rtl-button.js +++ b/lib/editor/atto/plugins/rtl/yui/build/moodle-atto_rtl-button/moodle-atto_rtl-button.js @@ -43,7 +43,8 @@ Y.namespace('M.atto_rtl').Button = Y.Base.create('button', Y.M.editor_atto.Edito title: direction, buttonName: direction, callback: this._toggleRTL, - callbackArgs: direction + callbackArgs: direction, + tags: '[dir=ltr]' }); direction = 'rtl'; @@ -52,7 +53,8 @@ Y.namespace('M.atto_rtl').Button = Y.Base.create('button', Y.M.editor_atto.Edito title: direction, buttonName: direction, callback: this._toggleRTL, - callbackArgs: direction + callbackArgs: direction, + tags: '[dir=rtl]' }); }, diff --git a/lib/editor/atto/plugins/rtl/yui/src/button/js/button.js b/lib/editor/atto/plugins/rtl/yui/src/button/js/button.js index 2fb15438e66d4..a755c355fec9c 100644 --- a/lib/editor/atto/plugins/rtl/yui/src/button/js/button.js +++ b/lib/editor/atto/plugins/rtl/yui/src/button/js/button.js @@ -41,7 +41,8 @@ Y.namespace('M.atto_rtl').Button = Y.Base.create('button', Y.M.editor_atto.Edito title: direction, buttonName: direction, callback: this._toggleRTL, - callbackArgs: direction + callbackArgs: direction, + tags: '[dir=ltr]' }); direction = 'rtl'; @@ -50,7 +51,8 @@ Y.namespace('M.atto_rtl').Button = Y.Base.create('button', Y.M.editor_atto.Edito title: direction, buttonName: direction, callback: this._toggleRTL, - callbackArgs: direction + callbackArgs: direction, + tags: '[dir=rtl]' }); },