MDL-35155 dml: add unit test which exposes substr problem

Previously, when using parameters, substring broke on mssql.
moodle · Jan 8, 2015 · fa01f2b · fa01f2b
1 parent 48ddb79
commit fa01f2b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/lib/dml/tests/dml_test.php b/lib/dml/tests/dml_test.php
@@ -4026,6 +4026,10 @@ public function test_sql_substring() {
         } catch (moodle_exception $e) {
             $this->assertInstanceOf('coding_exception', $e);
         }
+
+        $sql = "SELECT id, ".$DB->sql_substr("name", ":param1 + 1")." AS name FROM {{$tablename}}";
+        $record = $DB->get_record_sql($sql, array('param1' => 4));
+        $this->assertEquals(substr($string, 5-1), $record->name);
     }
 
     public function test_sql_length() {