Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

MDL-37988 Completion reports: Table header row not in thead section

  • Loading branch information...
commit fea8be420338f0df49606ade33dc062d40bfa461 1 parent 78129ff
Jérôme Mouneyrac mouneyrac authored danpoltawski committed
7 report/completion/index.php
@@ -314,7 +314,7 @@
314 314 print '<table id="completion-progress" class="generaltable flexible boxaligncenter completionreport" style="text-align: left" cellpadding="5" border="1">';
315 315
316 316 // Print criteria group names
317   - print PHP_EOL.'<tr style="vertical-align: top">';
  317 + print PHP_EOL.'<thead><tr style="vertical-align: top">';
318 318 echo '<th scope="row" class="rowheader" colspan="' . $leftcols . '">' .
319 319 get_string('criteriagroup', 'completion') . '</th>';
320 320
@@ -511,8 +511,9 @@
511 511 print '<img src="'.$OUTPUT->pix_url('i/course').'" class="icon" alt="'.get_string('course').'" title="'.get_string('coursecomplete', 'completion').'" />';
512 512 print '</th>';
513 513
514   - print '</tr>';
  514 + print '</tr></thead>';
515 515
  516 + echo '<tbody>';
516 517 } else {
517 518 // The CSV headers
518 519 $row = array();
@@ -730,6 +731,8 @@
730 731
731 732 if ($csv) {
732 733 $export->download_file();
  734 +} else {
  735 + echo '</tbody>';
733 736 }
734 737
735 738 print '</table>';
6 report/progress/index.php
@@ -280,7 +280,7 @@ function csv_quote($value) {
280 280 }
281 281
282 282 print '<div id="completion-progress-wrapper" class="no-overflow">';
283   - print '<table id="completion-progress" class="generaltable flexible boxaligncenter" style="text-align:left"><tr style="vertical-align:top">';
  283 + print '<table id="completion-progress" class="generaltable flexible boxaligncenter" style="text-align:left"><thead><tr style="vertical-align:top">';
284 284
285 285 // User heading / sort option
286 286 print '<th scope="col" class="completion-sortchoice">';
@@ -343,7 +343,7 @@ function csv_quote($value) {
343 343 if ($csv) {
344 344 print $line;
345 345 } else {
346   - print '</tr>';
  346 + print '</tr></thead><tbody>';
347 347 }
348 348
349 349 // Row for each user
@@ -415,7 +415,7 @@ function csv_quote($value) {
415 415 if ($csv) {
416 416 exit;
417 417 }
418   -print '</table>';
  418 +print '</tbody></table>';
419 419 print '</div>';
420 420 print $pagingbar;
421 421

0 comments on commit fea8be4

Please sign in to comment.
Something went wrong with that request. Please try again.