Permalink
Browse files

MDL-37988 Completion reports: Table header row not in thead section

  • Loading branch information...
1 parent 78129ff commit fea8be420338f0df49606ade33dc062d40bfa461 @mouneyrac mouneyrac committed with danpoltawski Apr 10, 2013
Showing with 8 additions and 5 deletions.
  1. +5 −2 report/completion/index.php
  2. +3 −3 report/progress/index.php
View
7 report/completion/index.php
@@ -314,7 +314,7 @@
print '<table id="completion-progress" class="generaltable flexible boxaligncenter completionreport" style="text-align: left" cellpadding="5" border="1">';
// Print criteria group names
- print PHP_EOL.'<tr style="vertical-align: top">';
+ print PHP_EOL.'<thead><tr style="vertical-align: top">';
echo '<th scope="row" class="rowheader" colspan="' . $leftcols . '">' .
get_string('criteriagroup', 'completion') . '</th>';
@@ -511,8 +511,9 @@
print '<img src="'.$OUTPUT->pix_url('i/course').'" class="icon" alt="'.get_string('course').'" title="'.get_string('coursecomplete', 'completion').'" />';
print '</th>';
- print '</tr>';
+ print '</tr></thead>';
+ echo '<tbody>';
} else {
// The CSV headers
$row = array();
@@ -730,6 +731,8 @@
if ($csv) {
$export->download_file();
+} else {
+ echo '</tbody>';
}
print '</table>';
View
6 report/progress/index.php
@@ -280,7 +280,7 @@ function csv_quote($value) {
}
print '<div id="completion-progress-wrapper" class="no-overflow">';
- print '<table id="completion-progress" class="generaltable flexible boxaligncenter" style="text-align:left"><tr style="vertical-align:top">';
+ print '<table id="completion-progress" class="generaltable flexible boxaligncenter" style="text-align:left"><thead><tr style="vertical-align:top">';
// User heading / sort option
print '<th scope="col" class="completion-sortchoice">';
@@ -343,7 +343,7 @@ function csv_quote($value) {
if ($csv) {
print $line;
} else {
- print '</tr>';
+ print '</tr></thead><tbody>';
}
// Row for each user
@@ -415,7 +415,7 @@ function csv_quote($value) {
if ($csv) {
exit;
}
-print '</table>';
+print '</tbody></table>';
print '</div>';
print $pagingbar;

0 comments on commit fea8be4

Please sign in to comment.