Permalink
Browse files

MDL-39414 portfolio: don't queue google portfolio exports

This is a bit of an ugly way of saying 'I dont support queued exports'.

The google plugins need a valid user session in order to export to the
google services, thereforce we are forcing the export to be interactive
and not queued through cron, as this wont work in the current
implmenetation.

It's possible we could add offline access to the plugins, but I don't
believe it is worth the benefit for the additional complexity.
  • Loading branch information...
1 parent 5e00b9a commit ff016927657f41ba1ec1f8894fe13e60a5de6569 @danpoltawski danpoltawski committed Apr 30, 2013
Showing with 6 additions and 3 deletions.
  1. +3 −2 portfolio/googledocs/lib.php
  2. +3 −1 portfolio/picasa/lib.php
@@ -44,8 +44,9 @@ public function get_interactive_continue_url() {
}
public function expected_time($callertime) {
- // We trust what the portfolio says.
- return $callertime;
+ // We're forcing this to be run 'interactively' because the plugin
+ // does not support running in cron.
+ return PORTFOLIO_TIME_LOW;
}
public function send_package() {
View
@@ -44,7 +44,9 @@ public function get_interactive_continue_url() {
}
public function expected_time($callertime) {
- return $callertime;
+ // We're forcing this to be run 'interactively' because the plugin
+ // does not support running in cron.
+ return PORTFOLIO_TIME_LOW;
}
public function send_package() {

0 comments on commit ff01692

Please sign in to comment.