Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

MDL-14492 Remove duplicate lines. scorm_resize() tries to set -ve heights if user specifies a small area. #24

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

badrul commented Apr 21, 2011

The problem reappears in Moodle 2.x and Moodle 1.9.11.

Sorry I've been searching http://tracker.moodle.org/ but couldn't find a link to create PULL request from there.

Remove duplicate lines. Sanity checking for scorm_resize() as it trie…
…s to set -ve heights if user specifies a small area.
Contributor

danmarsden commented Sep 29, 2011

this patch appears to be for rd.js which isn't actually used in the 2.0 branch (we forgot to delete it) - it's been deleted in the 2.2 branch (MDL-28601) but left in the old branches even though it isn't used.

rd.js hasn't been used since the patch in MDL-22951 so it should be safe to just delete the file from your 2.X installation.

I accept it might still be an issue in the 1.9 branch but the player in 1.9 has a range of other issues too and my main focus has been on 2.0

thanks!

Contributor

danmarsden commented Sep 29, 2011

  • also Pull requests cannot be made by the general public - if you see a bug in Moodle, please create a new Tracker issue and link to your Git repo with the suggested change.

thanks!

Owner

stronk7 commented Oct 1, 2011

Clossing this as stated by Dan, thanks!

@stronk7 stronk7 closed this Oct 1, 2011

marinaglancy pushed a commit to marinaglancy/moodle that referenced this pull request Nov 10, 2011

MorrisR2 pushed a commit to MorrisR2/moodle that referenced this pull request Aug 13, 2013

ds125v pushed a commit to ds125v/moodle that referenced this pull request Jan 10, 2014

ctam pushed a commit to ucsf-ckm/moodle that referenced this pull request Nov 30, 2015

Fix issue #24 - mod/kalvidpres/lib.php needs tidying up:
1. Fix documentation for kalvidpres_get_participants()
2. Remove unreachable code from kalvidpres_supports()

ctam pushed a commit to ucsf-ckm/moodle that referenced this pull request Nov 30, 2015

Merge pull request #31 from barrysspace/MDL27_fix_24_tidy_up
Fix issue #24 -  mod/kalvidpres/lib.php needs tidying up:

BenKelada pushed a commit to BenKelada/moodle that referenced this pull request Jun 24, 2016

Merged in LT-1623 (pull request #24)
LT-1623: Add ability to have image and text for cobranding.

ctam pushed a commit to ucsf-ckm/moodle that referenced this pull request Mar 27, 2017

Fix issue #24 - mod/kalvidpres/lib.php needs tidying up:
1. Fix documentation for kalvidpres_get_participants()
2. Remove unreachable code from kalvidpres_supports()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment