Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pg10 bump #53

Merged
merged 2 commits into from Jun 22, 2021
Merged

Pg10 bump #53

merged 2 commits into from Jun 22, 2021

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Jun 21, 2021

Bump to PG10 because it's going to be a requirement for Moodle 4.0 and up (see MDL-70594).

It comes with a few changes about replication stuff, following the information @ https://www.postgresql.org/docs/10/release-10.html

  • rename functions, tools and options referencing "xlog" to "wal".
  • log_directory changed from "pg_log" to "log".

Note that both:

  • wal-method=stream
  • log_directory=log

are default options so, extrictly speaking we shouldn't need to set them but it doesn't hurt to have them explicily defined, so keeping them.

Launching some jobs @ Ci...

Following the information @ https://www.postgresql.org/docs/10/release-10.html
- rename functions, tools and options referencing "xlog" to "wal".
- log_directory changed from "pg_log" to "log".

Note that both:
- wal-method=stream
- log_directory=log

are default options so, extrictly speaking we shouldn't need to set them
but it doesn't hurt to have them explicily defined, so keeping them.
@stronk7
Copy link
Member Author

stronk7 commented Jun 21, 2021

  • PG10, replicas enabled.
    • phpunit: Build Status
    • goutte: Build Status
    • firefox: Build Status
  • PG10, standalone:
    • phpunit: Build Status
    • goutte: Build Status
    • firefox: Build Status

Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. Thanks for working on this, Eloy!

@sarjona sarjona merged commit 90e2530 into moodlehq:master Jun 22, 2021
@stronk7 stronk7 deleted the pg10_bump branch June 22, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants