Temporary fix for the problems with Chrome 76+/MDL-66378 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnicols
approved these changes
Aug 14, 2019
|
Thanks Tim, That patch works nicely. Chrome have fixed the issue with empty body in 76 but I feel we should keep it in for now anyway. |
stronk7
added a commit
to stronk7/moodle-ci-runner
that referenced
this pull request
Sep 11, 2019
With MDL-66378 and, specially, moodlehq/php-webdriver#1 we can continue using Chrome >= 76 because we are enforcing the use of the legacy JsonWire protocol (instead of the default W3C one). So it has been agreed that we'll allow any 3.x new release to be used in order to detect problems earlier (we always can pin again if needed).
stronk7
added a commit
to moodlehq/moodle-docker
that referenced
this pull request
Sep 11, 2019
With [MDL-66378](https://tracker.moodle.org/browse/MDL-66378) and, specially, moodlehq/php-webdriver#1 we can continue using Chrome >= 76 because we are enforcing the use of the legacy JsonWire protocol (instead of the default W3C one). So it has been agreed that we'll allow any 3.x new release to be used in order to detect problems earlier (we always can pin again if needed).
This was referenced Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.