Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent handling of HTML tags in topic and knowledge #24

Closed
mudrd8mz opened this issue Nov 16, 2016 · 2 comments
Closed

Inconsistent handling of HTML tags in topic and knowledge #24

mudrd8mz opened this issue Nov 16, 2016 · 2 comments

Comments

@mudrd8mz
Copy link

If I specify the topics with HTML tags (such as <h1>Topic 1</h1>, <h1>Topic 2</h1> etc) and use the same for the list of knowledge questions, the behaviour is inconsistent.

  • Knowledge questions seem to be handled differently from topics.
  • Things look differently in the preview and then later in actual usage.

Maybe you want to simply consider all these fields as plain text fields and always use the s() function when printing them via PHP, and the appropriate way to handle them via JS.

@jkonert
Copy link
Member

jkonert commented Feb 20, 2017

Tag usage in topics/knowledge leads to empty fields in questionnaire. Better behaviour: Convert all tags to HTML safe representation.

@rroepke
Copy link
Member

rroepke commented Feb 20, 2017

Maybe you can find the thing to change in settings_functions.js such that in the knowledge-preview in the settings possible HTML is displayed correctly. For topics, this already is implemented but I couldn't figure out how

jkonert added a commit that referenced this issue Feb 27, 2017
jkonert added a commit that referenced this issue Feb 27, 2017
…ing was different and thus interpreted html-tags; now fixed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants