Don't shim <- and {

[krlmlr]

to avoid repetition of output.

library(boomer)
library(tidyverse)

test <- boomer::rigger() + function() {
  a <- 1 + 2 * 3
}

test()
#> 2 * 3
#> [1] 6
#> 1 + 2 * 3
#> [1] 7
#> a <- 1 + 2 * 3
#> [1] 7
#> {
#>     a <- 1 + 2 * 3
#> }
#> [1] 7
#> [1] 7

^{Created on 2021-04-26 by the reprex package (v2.0.0)}

[moodymudskipper]

It would make sense most of the time, but in some corner cases it would prevent {boomer}, from spotting that one of these is overridden.

I think we can have an additional argument ignore defaulting to a vector of those you suggest + other assignment ops and parenthesis.

The doc would mention that :: and ::: are never boomed.

[krlmlr]

Added to PR.

[moodymudskipper]

@krlmlr thanks, I've updated it to use options by default so the behavior of the addin can be easily modified too. And I've added "=" to the list of ignored functions.

1a11a91

[krlmlr]

The "=" gives weird behavior on my end, I use ignore = c("~", "{", "(", "<-", "<<-") for now.

[moodymudskipper]

Do you have something reproducible ?

[krlmlr]

Not yet. The error message mentioned names<- and .Primitive("<-"), I was happy to find the workaround 😅

[moodymudskipper]

Since we've had quite a few changes since then and don't have anything reproducible, I'm closing for now

[krlmlr]

Today:

library(boomer)
library(tidyverse)

test <- boomer::rigger() + function() {
  a <- 1 + 2 * 3
}

test()
#> 👇 e2
#> 💣 +
#> · 💣 *
#> · 💥 2 * 3
#> · [1] 6
#> · 
#> 💥 1 + 2 * 3
#> [1] 7
#> 
#> 👆 e2

^{Created on 2021-06-11 by the reprex package (v2.0.0)}

I think it's fine, thanks for looking into it!

[github-actions]

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.