Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

Dotfile passenger #41

Merged
merged 3 commits into from Feb 27, 2014
Merged

Dotfile passenger #41

merged 3 commits into from Feb 27, 2014

Conversation

moonglum
Copy link
Owner

Refactored the dotfile passenger. Enhanced Executor#ln_s. Added method to get a path in the working directory to the Executor. Added Tests for the dotfile passenger.

@moonglum
Copy link
Owner Author

I simplified that a lot. Will write the tests for it and then push it. This evening maybe? 😸

moonglum added 3 commits February 26, 2014 23:34
Wrapper around FileUtils#ln_s
Equivalent in functionality to
Executor#get_path_in_home
@moonglum
Copy link
Owner Author

Ready for review, @bitboxer 😉

@bitboxer
Copy link
Collaborator

Just realized that we don't have any tests for the executor. But the dotfiles stuff is looking good. Feel free to merge 👍

moonglum added a commit that referenced this pull request Feb 27, 2014
@moonglum moonglum merged commit f395394 into master Feb 27, 2014
@moonglum moonglum deleted the dotfile-passenger branch February 27, 2014 09:07
@moonglum
Copy link
Owner Author

Thanks 😸

Yes, that is true. And it is something really ugly to test. As with the output stuff, I want to extract it into a different gem. This would then be tested with something like test construct. But first I want the API of the executor to solidify – there are some things that are bugging me right now 😉 Therefore it is part of the next milestone, not this one!

@moonglum
Copy link
Owner Author

I think the executor will become a mashup of the excellent standard libraries FileUtils and PathName plus nice output via Megingiard.

@bitboxer
Copy link
Collaborator

Oh, i didn't know test construct. Looks really nice.

@moonglum
Copy link
Owner Author

Yep 😉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants