Skip to content
This repository has been archived by the owner. It is now read-only.

Remove setrlimit on FreeBSD #1

Merged
merged 1 commit into from
May 21, 2019
Merged

Remove setrlimit on FreeBSD #1

merged 1 commit into from
May 21, 2019

Conversation

valpackett
Copy link

@valpackett valpackett commented May 20, 2019

An embeddable interpreter setting a limit that's inherited by spawned child processes is a disaster.. (in fact, the weird limit in Neovim's terminal was what caused me to discover this.)

This code is a relic from the FreeBSD <10 days, and the check for FreeBSD version was not correct (__FreeBSD_kernel__ is defined anyway on newer versions). Let's just get rid of this.

--

ref: LuaJIT#332

An embeddable interpreter setting a limit that's inherited by spawned child processes is a disaster.. (in fact, the weird limit in Neovim's terminal was what caused me to discover this.)

This code is a relic from the FreeBSD <10 days, and the check for FreeBSD version was not correct (__FreeBSD_kernel__ is defined anyway on newer versions). Let's just get rid of this.
@siddhesh siddhesh merged commit b747368 into moonjit:v2.1 May 21, 2019
@siddhesh
Copy link
Collaborator

Thanks for the patch, merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants