Small improvements #162
Small improvements #162
Conversation
Stop referring the reader to the next sentence.
I don't understand the previous documentation, but having read the code I've rewritten what I think it was trying to explain. I hope I'm right.
| @@ -946,8 +946,7 @@ sub superclasses { | |||
| my $isa = $self->get_or_add_package_symbol('@ISA'); | |||
|
|
|||
| if (@_) { | |||
| my @supers = @_; | |||
| @{$isa} = @supers; | |||
| @{$isa} = @_; | |||
There was a problem hiding this comment.
I have to wonder if this code was the way it was because of some weird corner case with @_. Of course, there was no comment there and this isn't causing a test failure, so I'm probably being unnecessarily paranoid.
|
This pull request has been open for more than two years. It fixes problems in Moose's documentation. I welcome suggestions for what I might do to get these fixes merged. |
|
The process is to post a new comment, requesting that a maintainer take a look and merge it or comment on it. There's nothing more magical than that -- no one these days is going through all of the repositories they have merge access to and looking for things; they just need a poke. Thank you for the reminder, and I will merge it today. |
|
I omitted the middle commit; the history might be revealing there but it is back in the Class-MOP repository, which I do not have archived. |
|
Many thanks, @karenetheridge |
No description provided.