Topic/structured exceptions #37

Closed
wants to merge 2,251 commits into
from

Projects

None yet

3 participants

@upasana-me
Member

No description provided.

upasana-me added some commits Sep 14, 2013
@upasana-me upasana-me fixed indentation dd39530
@upasana-me upasana-me Replaced throw_error with throw_exception 774ea8c
@upasana-me upasana-me Wrote tests for HandOptimizedTypeConstraintIsNotCodeRef 52c6828
@upasana-me upasana-me Wrote HandOptimizedTypeConstraintIsNotCodeRef 877c613
@upasana-me upasana-me Deleted SingleParamsToNewMustBeHRef & IncompatibleMetaclassOfSuperclass db6d81f
@upasana-me upasana-me removed whitespace fed2649
@upasana-me upasana-me annotated tests for documentation 0685ca0
@upasana-me upasana-me Wrote AttributeNamesDoNotMatch & NeitherAttributeNorAttributeNameIsGiven c51c623
@upasana-me upasana-me Wrote tests for Moose::Meta::Method::Accessor::Native::grep 8bc5d76
@upasana-me upasana-me Wrote tests for exception LazyAttributeNeedsADefault ef0ccde
@upasana-me upasana-me Wrote role for attribute_name 8bd2c50
@upasana-me upasana-me replaced _inline_throw_error with _inline_throw_exception a2388f8
@upasana-me upasana-me wrote tests for AttributeIsRequired 5fffd44
@upasana-me upasana-me Wrote comment for not converting error to structured exception 68f6bf5
@upasana-me upasana-me Removed whitespace f79ec28
@upasana-me upasana-me changed exception name & used Moose::Exception::Role::Class 6ac1c88
@upasana-me upasana-me Deleted MustSupplyAnArrayRefAsCurriedArguments 1434ecc
@upasana-me upasana-me replaced confess with throw_exception b29cb21
@upasana-me upasana-me Corrected exception's name 493e454
@upasana-me upasana-me Wrote tests for MustSupplyArrayRefAsCurriedArguments d93eb72
@upasana-me upasana-me corrected exception name 90ba645
@upasana-me upasana-me corrected exception name 8b0c8a8
@upasana-me upasana-me fixed indentation 1b894d5
@upasana-me upasana-me improved delegation methods ec07654
@upasana-me upasana-me made changes to tests of OverrideConflictInSummation 386e691
@upasana-me upasana-me no need to handle hand optimized typeconstraint, it's removed now ad88cd2
@upasana-me upasana-me removed tests for hand-optimized typeconstraint exception b717e72
@upasana-me upasana-me replaced ref with blessed 1bf9d13
@upasana-me upasana-me removed 'An' from the exception name d336dc8
@upasana-me upasana-me removed article from exception name b8f7781
@upasana-me upasana-me added comment for intention syntax error a47ba13
@upasana-me upasana-me fixed indentation ee8bed8
@upasana-me upasana-me removed redundant delegation methods e496ebe
@upasana-me upasana-me Wrote EitherAttributeOrAttributeName
Some exceptions take either attribute or attribute_name or both,
so I have written this role for such exceptions
7857486
@upasana-me upasana-me Used EitherAttributeOrAttributeName role 5fe8976
@upasana-me upasana-me replaced confess with throw_exception 7767079
@upasana-me upasana-me Wrote tests for CannotAssignValueToReadOnlyAccessor 94f821f
@upasana-me upasana-me used EitherAttributeOrAttributeName role baa4b52
@upasana-me upasana-me used IncompatibleMetaclassOfSuperclass
changing exception message is not recommended, it may lead to some tests failiures, so using IncompatibleMetaclassOfSuperclass
7489d96
@upasana-me upasana-me changed tests for IncompatibleMetaclassOfSuperclass 1771d78
@upasana-me upasana-me Wrote IncompatibleMetaclassOfSuperclass 899ffdf
@upasana-me upasana-me replaced confess with throw_exception 22f120c
@upasana-me upasana-me Wrote metaclass incompatibility exceptions for Class::MOP::Class 03b9107
@upasana-me upasana-me Wrote tests for metaclass compatibility exceptions of Class::MOP::Class a349e59
@upasana-me upasana-me replaced confess with throw_exception & minor modification in _anon_c…
…ache_key
a2e4dd2
@upasana-me upasana-me Wrote exception PackagesAndModuleAreNotCachable d741080
@upasana-me upasana-me Wrote tests for exception PackagesAndModuleAreNotCachable ce4a505
@upasana-me upasana-me replaced confess with throw_exception & minor modification in _anon_c…
…ache_key
0f247ee
@upasana-me upasana-me Wrote tests for exception PackagesAndModuleAreNotCachable 2338e43
@upasana-me upasana-me Using role EitherAttributeOrAttributeName,so removed the redundant code 5b74cac
@upasana-me upasana-me replaced die & throw_error with throw_exception e182f8f
@upasana-me upasana-me Wrote exceptions for Moose::Exporter 531ee9a
@upasana-me upasana-me wrote tests for exceptions in Moose::Exporter c52cbc6
@upasana-me upasana-me replaced throw_error with throw_exception 60a8a84
@upasana-me upasana-me Wrote tests for UnableToRecognizeDelegateMetaclass 356c86a
@upasana-me upasana-me wrote UnableToRecognizeDelegateMetaclass a9530bd
@upasana-me upasana-me replaced confess with throw_exception 4f6b0bd
@upasana-me upasana-me replaced throw_error with throw_exception 83a3981
@upasana-me upasana-me wrote tests for CouldNotParseType 613c8be
@upasana-me upasana-me wrote CouldNotParseType 2bc377c
@upasana-me upasana-me Replaced throw_error with confess(not a structured exception) 2ced5c3
@upasana-me upasana-me removed trailing whitespace 547a371
@upasana-me upasana-me Wrote documentation generator for documenting exception classes e4ead37
@upasana-me upasana-me replaced throw_error with confess (not a structured exception) 97b8c09
@upasana-me upasana-me replaced throw_error with confess (not a structured exception) 65dd883
@upasana-me upasana-me Removed extra line a1447ec
@upasana-me upasana-me renamed package_or_module to is_module 833c02f
@upasana-me upasana-me Renamed package_or_module to is_module & made it Bool 83f3e8b
@upasana-me upasana-me Removed redundant code (moved it in the exception) 246691e
@upasana-me upasana-me Renamed package_or_module to is_module b54ce8d
@upasana-me upasana-me removed whitespace 523f7e6
@upasana-me upasana-me replaced throw_error with throw_exception de70059
@upasana-me upasana-me Wrote exception CouldNotEvalCreateWriter b88dbe4
@upasana-me upasana-me Changed type of error, error isa Str|Moose::Exception
This exception can have CouldNotCreateWriter as an error, so error should be 'Str|Moose::Exception'
5966fdb
@upasana-me upasana-me Wrote tests for CouldNotCreateWriter ce3493d
@upasana-me upasana-me Removed data which I added by mistake 8673ead
@upasana-me upasana-me deleted moose-meta-method-accessor.t f304a3a
@upasana-me upasana-me Wrote tests for CouldNotCreateWriter 7055414
@upasana-me upasana-me Replaced confess with throw_exception 53c9e42
@upasana-me upasana-me Wrote tests for CouldNotEvalConstructor d03d59f
@upasana-me upasana-me Wrote exception CouldNotEvalConstructor a677c09
@upasana-me upasana-me removed reftype while merging conflicts, so added refype 78a81d3
@upasana-me upasana-me get rid of warning due to undefined {body} 52e05ba
@upasana-me upasana-me get rid of deprecated hand-optimized type constraint e2b6b99
@upasana-me upasana-me written test for extends b5cd17c
@upasana-me upasana-me Wrote test case for Moose::Exception::ExtendsMissingArgs object 597682f
@upasana-me upasana-me Added message and _build_message to Exception.pm 0e9c460
@upasana-me upasana-me load Class::MOP at runtime,to prevent circular dependency 45f3956
@upasana-me upasana-me lost this while resolving merge conflicts c1708d1
@upasana-me upasana-me Pass ARRAY ref to enum 75824a2
@upasana-me upasana-me Pass ARRAY ref to enum 0f65a5b
@upasana-me upasana-me This exception has been replaced by MustPassEvenNumberOfAttributeOptions f2ad932
@upasana-me upasana-me replaced InvalidHasProvided by MustPassEvenNumberOfAttributeOptions 8f40a59
@upasana-me upasana-me replaced throw_error with throw_exception a7d1146
@upasana-me upasana-me removed tests for InvalidHasProvided c6e1da9
@upasana-me upasana-me Wrote tests for exceptions in Moose::Meta::Attribute 7a5c0ec
@upasana-me upasana-me Wrote CannotCoerceAttributeWhichHasNoCoercion for Moose::Meta::Attribute de4ff62
@upasana-me upasana-me Corrected exception message eb0b629
@upasana-me upasana-me replaced throw_error with throw_exception 41f9ced
@upasana-me upasana-me Wrote tests for exception in Moose::Util ca2df4a
upasana-me added some commits Jul 10, 2013
@upasana-me upasana-me wrote tests for AttributeIsRequired in Moose::Meta::Attribute::set_value 91c8a6f
@upasana-me upasana-me wrote tests for ValidationFailedForTypeConstraint d27c034
@upasana-me upasana-me wrote tests for UnableToCanonicalizeHandles & UnableToCanonicalizeNon…
…RolePackage
7fb4029
@upasana-me upasana-me Wrote tests for DelegationToAClassWhichIsNotLoaded d4dc945
@upasana-me upasana-me Wrote tests for DelegationToARoleWhichIsNotLoaded 8b37707
@upasana-me upasana-me corrected exception message of DelegationToARoleWhichIsNotLoaded 8ab9b93
@upasana-me upasana-me Wrote tests for DelegationToATypeWhichIsNotAClass 6b61686
@upasana-me upasana-me Wrote tests for CannotFindDelegateMetaClass 8bd45ed
@upasana-me upasana-me replaced throw_error with throw_exception d13e790
@upasana-me upasana-me wrote tests for BadHasProvided 463c0e8
@upasana-me upasana-me Wrote class BadHasProvided f943c6b
@upasana-me upasana-me Wrote tests for NeitherClassNorClassNameIsGiven (thrown in Moose::Exc…
…eption::Role::Class)
5235f9e
@upasana-me upasana-me fixed indentation 8cf9a27
@upasana-me upasana-me Wrote tests for InitMetaRequiresClass 7ab99ed
@upasana-me upasana-me Wrote tests for MetaclassNotLoaded 0cfb8fb
@upasana-me upasana-me Wrote tests for MetaclassMustBeASubclassOfMooseMetaClass 242b502
@upasana-me upasana-me replaced throw_error with throw_exception & added tests for RolesDoNo…
…SupportExtends
fd9d841
@upasana-me upasana-me Wrote tests for MustSpecifyAtleastOneMethod ebf1987
@upasana-me upasana-me Wrote tests for Moose::EXception::Role::Role d8bc61e
@upasana-me upasana-me Wrote tests for MustSpecifyAtleastOneRole e8051c4
@upasana-me upasana-me Wrote tests for RolesDoNotSupportInner 4f6a8d2
@upasana-me upasana-me wrote tests for RolesDoNotSupportAugment 51cb7ea
@upasana-me upasana-me Wrote some more tests for DoesRequiresRoleName 70699e4
@upasana-me upasana-me Wrote tests for MustSpecifyAtleastOneRoleToApplicant 9991791
@upasana-me upasana-me CannotAddAsAnAttributeToARole 91e44ff
@upasana-me upasana-me Wrote tests for AttributeExtensionIsNotSupportedInRoles 0c6b802
@upasana-me upasana-me Wrote tests for CannotOverrideALocalMethod d8ab058
@upasana-me upasana-me Wrote tests for AddRoleToARoleTakesAMooseMetaRole 03ece2f
@upasana-me upasana-me Added more tests for AddRoleTakesAMooseMetaRoleInstance 10130a9
@upasana-me upasana-me Added more tests for RoleNameRequired (for Moose::Meta::Class) 3b52556
@upasana-me upasana-me replaced throw_error with throw_exception & wrote tests for RoleNameR…
…equiredForMooseMetaRole
196f609
@upasana-me upasana-me replaced throw_error with throw_exception & wrote tests for ApplyTake…
…sABlessedInstance
8e2f385
@upasana-me upasana-me Wrote tests for exceptions in Moose::Meta::Role::create method e1046c1
@upasana-me upasana-me changed sub foo in override exception to foo2,because it's already de…
…fined in augment exception
c9a425c
@upasana-me upasana-me changed test description for CannotOverrideLocalMethodIsPresent b032a63
@upasana-me upasana-me made a different file for exceptions thrown in lib/Moose/Object.pm c5a8715
@upasana-me upasana-me Wrote tests for UnionTakesAtleastTwoTypeNames & CouldNotLocateTypeCon…
…straintForUnion
a40f9c8
@upasana-me upasana-me added tests for InvalidTypeGivenToCreateParameterizedTypeConstraint &…
… InvalidBaseTypeGivenToCreateParameterizedTypeConstraint
8349d29
@upasana-me upasana-me Wrote tests for TypeConstraintIsAlreadyCreated c3eb323
@upasana-me upasana-me corrected test message a5d396b
@upasana-me upasana-me wrote tests for NoParentGivenToSubtype c44cad7
@upasana-me upasana-me added tests for EnumCalledWithAnArrayRefAndAdditionalArgs 0b8f590
@upasana-me upasana-me wrote tests for UnionCalledWithAnArrayRefAndAdditionalArgs 2f0a421
@upasana-me upasana-me Wrote tests for TypeConstraintIsAlreadyCreated,CannotFindType & AddPa…
…rameterizableTypeTakesParameterizableType
50b1664
@upasana-me upasana-me removed use Carp 'confess'; because now it's redundant 354266e
@upasana-me upasana-me Wrote MustSupplyADelegateToMethod,MustSupplyAMooseMetaAttributeInstan…
…ce & MustSupplyAnArrayRefAsCurriedArguments
c6d7f96
@upasana-me upasana-me Added tests for MetaclassIsARoleNotASubclassOfGivenMetaclass & Metacl…
…assIsNotASubclassOfGivenMetaclass
d4421e7
@upasana-me upasana-me Changed BadHasProvided to InvalidHasProvided f65eb6c
@upasana-me upasana-me Changed BadHasProvided to InvalidHasProvided 0527ffc
@upasana-me upasana-me Wrote exception class OverrideMethodConflictInRoleComposition 3583338
@upasana-me upasana-me Added second_role attribute to RoleDoesTheExcludedRole 8eeacae
@upasana-me upasana-me Wrote tests for exceptions in Moose::Meta::Method::Delegation df9262f
@upasana-me upasana-me Use CannotMakeMetaclassCompatible for all metaclass compatibility exc…
…eptions
17165db
@upasana-me upasana-me Wrote CouldNotEvalDestructor 976564a
@upasana-me upasana-me Removed whitespace b933361
@upasana-me upasana-me Use one exception for superclass metaclass incompatibility
For all the exceptions which are related to metaclass incompatibility of superclasses, use CannotMakeMetaclassCompatible, doy said this.
3268059
@upasana-me upasana-me Wrote exceptions for Moose::Util::TypeConstraints 4430c82
@upasana-me upasana-me Replaced throw_error with throw_exception bcd5c03
@upasana-me upasana-me Wrote tests for HandOptimizedTypeConstraintIsNotCodeRef 3f32651
@upasana-me upasana-me Wrote HandOptimizedTypeConstraintIsNotCodeRef 21fe82d
@upasana-me upasana-me Deleted MustSupplyAnArrayRefAsCurriedArguments 44f16f5
@upasana-me upasana-me no need to handle hand optimized typeconstraint, it's removed now b11074f
@upasana-me upasana-me removed tests for hand-optimized typeconstraint exception 8f89f1d
@upasana-me upasana-me removed 'An' from the exception name 741a17c
@upasana-me upasana-me removed article from exception name 166a3ce
@upasana-me upasana-me used IncompatibleMetaclassOfSuperclass
changing exception message is not recommended, it may lead to some tests failiures, so using IncompatibleMetaclassOfSuperclass
676461b
@upasana-me upasana-me changed tests for IncompatibleMetaclassOfSuperclass 07b1a91
@upasana-me upasana-me deleted moose-meta-method-accessor.t 5d0b302
@upasana-me upasana-me Wrote tests for CouldNotCreateWriter 5cd0cdd
@upasana-me upasana-me lost this while resolving merge conflicts a1485f0
@upasana-me upasana-me Removed redundant throw_error & _inline_throw_error 8de8a23
@upasana-me upasana-me Made changes for getting exception message of CouldNotCreateWriter
documentation generator was unable to fetch exception message of CouldNotCreateWriter,
because it's thrown by another exception (CouldNotGenerateInlineAttributeMethod) unlike
other exceptions
b2cef83
@upasana-me upasana-me Wrote documentation of Moose::Exception 5def765
@upasana-me upasana-me Removed redundant use Class::Load 0.07 qw(load_class); 9eb2314
@upasana-me upasana-me Wrote documentation of Moose::Util::throw_exception dfbe36f
@upasana-me upasana-me Made type a duck-type, because of Specio, Type::Tiny etc. f8cfcbd
@upasana-me upasana-me Made changes in documentation 70e1be7
@upasana-me upasana-me find_meta should not load Class::MOP at runtime
Some tests were failing because of circular dependencies due to Moose::Util::throw_exception, so I loaded it at runtime.
7a37c29
@upasana-me upasana-me Wrote documentation for Exceptions a6dcf9d
@upasana-me upasana-me Made changes in Moose::Manual::Exceptions::Manifest 0528b5d
@upasana-me upasana-me Created Moose::Manual::Exceptions::Manifest.pod 903efa1
@upasana-me upasana-me Made changes for removing trailing whitespace d1f7101
@upasana-me upasana-me Adding documentation with removed trailing whitespace c2424e0
@upasana-me upasana-me Resolved a merge conflict c7490ea
@upasana-me upasana-me Resolved conflicts c0f03be
@upasana-me upasana-me Modified auto-generated documentation 1240afc
@upasana-me upasana-me Load Moose::Util::throw_exception at runtime b8a9e0f
@upasana-me upasana-me getExceptionsToMessages should be called only once 728d584
@upasana-me upasana-me Passed an array ref to enum d7b03f5
@upasana-me upasana-me removed trailing whitespace and tabs 187d145
@upasana-me upasana-me no need of pod's for Moose::Exception::* f2969f7
@upasana-me upasana-me Removed tab 693bb90
@upasana-me upasana-me Removed tabs ee4e278
@upasana-me upasana-me Ignore Moose::Exception::BUILD method in pod-coverage 1eac0f5
@upasana-me upasana-me Edited pod-spell.t de06757
@upasana-me upasana-me Made changes in the generated documentation 448964a
@upasana-me upasana-me Made changes in the documentation 72e8014
@doy
Member
doy commented Oct 18, 2013

The history on this branch is really weird, I'm going to try to clean it up before merging.

@sartak
Member
sartak commented Oct 18, 2013

Closing this in favor of #38

@sartak sartak closed this Oct 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment