New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/structured exceptions #37

Closed
wants to merge 2,251 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@upasana-me
Member

upasana-me commented Oct 18, 2013

No description provided.

upasana-me added some commits Sep 14, 2013

Wrote EitherAttributeOrAttributeName
Some exceptions take either attribute or attribute_name or both,
so I have written this role for such exceptions
used IncompatibleMetaclassOfSuperclass
changing exception message is not recommended, it may lead to some tests failiures, so using IncompatibleMetaclassOfSuperclass

upasana-me added some commits Sep 15, 2013

used IncompatibleMetaclassOfSuperclass
changing exception message is not recommended, it may lead to some tests failiures, so using IncompatibleMetaclassOfSuperclass
Made changes for getting exception message of CouldNotCreateWriter
documentation generator was unable to fetch exception message of CouldNotCreateWriter,
because it's thrown by another exception (CouldNotGenerateInlineAttributeMethod) unlike
other exceptions
find_meta should not load Class::MOP at runtime
Some tests were failing because of circular dependencies due to Moose::Util::throw_exception, so I loaded it at runtime.
@doy

This comment has been minimized.

Show comment
Hide comment
@doy

doy Oct 18, 2013

Member

The history on this branch is really weird, I'm going to try to clean it up before merging.

Member

doy commented Oct 18, 2013

The history on this branch is really weird, I'm going to try to clean it up before merging.

@sartak

This comment has been minimized.

Show comment
Hide comment
@sartak

sartak Oct 18, 2013

Member

Closing this in favor of #38

Member

sartak commented Oct 18, 2013

Closing this in favor of #38

@sartak sartak closed this Oct 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment