Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested browsers do not take "when", or "display" into account #228

Closed
seandenigris opened this issue Aug 3, 2015 · 5 comments
Closed

Nested browsers do not take "when", or "display" into account #228

seandenigris opened this issue Aug 3, 2015 · 5 comments

Comments

@seandenigris
Copy link
Contributor

seandenigris commented Aug 3, 2015

Originally reported on Google Code with ID 228

The when code like in the example below is not taken into account when establishing
the 
presentation.

... using: [
   (browser custom: nestedBrowser)
      when: [...] ]

Reported by tudor.girba on 2009-11-21 00:10:24

@seandenigris
Copy link
Contributor Author

seandenigris commented Aug 3, 2015

Reported by tudor.girba on 2009-12-21 12:27:33

@seandenigris
Copy link
Contributor Author

seandenigris commented Aug 3, 2015

You cannot transform the input before passing it into the browser.�

Reported by tudor.girba on 2009-12-21 12:28:38

  • Labels added: Priority-High
  • Labels removed: Priority-Medium

@seandenigris
Copy link
Contributor Author

seandenigris commented Aug 3, 2015

Reported by tudor.girba on 2010-09-05 09:14:03

  • Labels added: Milestone-4.2
  • Labels removed: Milestone-4.1

@seandenigris
Copy link
Contributor Author

seandenigris commented Aug 3, 2015

Reported by tudor.girba on 2011-01-28 12:22:24

  • Labels removed: Milestone-4.2

@seandenigris
Copy link
Contributor Author

seandenigris commented Aug 3, 2015

These work now:

nestedBrowser := GLMWrapper new show: [:a | a text ].
composite := GLMCompositePresentation new with: [:a | 
    (a custom: nestedBrowser)
      when: [ false ] ].
composite openOn: 'fourtytwo'.


nestedBrowser := GLMWrapper new show: [:a | a text ].
composite := GLMCompositePresentation new with: [:a | 
    (a custom: nestedBrowser)
      when: [ true ] ].
composite openOn: 'fourtytwo'.

Reported by tudor@tudorgirba.com on 2014-07-24 05:21:59

  • Status changed: Fixed
  • Labels added: Milestone-5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant